Skip to content

Linting fails on PRs from forked repos #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tbirdso opened this issue Mar 15, 2021 · 2 comments
Closed

Linting fails on PRs from forked repos #234

tbirdso opened this issue Mar 15, 2021 · 2 comments

Comments

@tbirdso
Copy link
Contributor

tbirdso commented Mar 15, 2021 •
edited
Loading

Summary

lint check passes on local checks in forked repo but fails in PR to dest repo due to annotation permissions.

Example: nbsphinx lint check passes in fork but fails in PR.

Expected behavior

Linting check passes for all valid PRs

Observed behavior

Error: This action does not have permission to create annotations on forks. You may want to run it only on push events. See wearerequired/lint-action#13 for details
Adding "tbirdso/ITKExamples" fork as remote with Git
Fetching remote branch "nbsphinx"
From https://github.com/tbirdso/ITKExamples

  • branch nbsphinx -> FETCH_HEAD
    Switching to the "nbsphinx" branch
  • [new branch] nbsphinx -> fork/nbsphinx
    Previous HEAD position was 77bb3ab Merge 47b9936 into 66453fd
    Switched to branch 'nbsphinx'
    SHA of last commit is "47b9936fb990ea891c14d43877723c1fc395ad99"
    Run Black
    Create check runs with commit annotations
    Creating GitHub check with 0 annotations for Black…
    Error: Error: Received status code 403
    Error: Error trying to create GitHub check for Black: Received status code 403
@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 15, 2021

@thewtex did you see this behavior in 6dd94077?

thewtex added a commit that referenced this issue Mar 15, 2021
@thewtex
BUG: Use super-linter GitHub Action for black linting
f8a4f2b 
Does not try to create an annotation, which is not permitted on forks
re: wearerequired/lint-action#13

Addresses #234
@thewtex thewtex mentioned this issue Mar 15, 2021
Merged
@thewtex
Copy link
Member

thewtex commented Mar 15, 2021

@tbirdso thanks for the note -- I had not encountered this, yet.

#235 attempts to address it.

thewtex added a commit that referenced this issue Mar 15, 2021
@thewtex
BUG: Use super-linter GitHub Action for black linting
2be5415 
Does not try to create an annotation, which is not permitted on forks
re: wearerequired/lint-action#13

Addresses #234
@thewtex thewtex closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thewtex @tbirdso