Skip to content

Commit b331d25

Browse files
committed
rename isEquals to isEqual
1 parent 6c053c7 commit b331d25

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# proposal-arraybuffer-equals
1+
# proposal-arraybuffer-equal
22

3-
This is a proposal to add a new method, `ArrayBuffer.isEquals(a: ArrayBuffer, b: ArrayBuffer)`,
3+
This is a proposal to add a new method, `ArrayBuffer.isEqual(a: ArrayBuffer, b: ArrayBuffer)`,
44
to JavaScript's `ArrayBuffer` class.
55

66
It has not yet been presented to the JavaScript standards committee.
@@ -31,7 +31,7 @@ To solve this problem, you need to define a method.
3131

3232
```typescript
3333
// The is TypeScript code
34-
function isEquals(a: ArrayBuffer, b: ArrayBuffer) {
34+
function isEqual(a: ArrayBuffer, b: ArrayBuffer) {
3535
if (!(a instanceof ArrayBuffer)) {
3636
return false;
3737
} else if (!(b instanceof ArrayBuffer)) {
@@ -61,21 +61,21 @@ Wait for enter stage 1, then publish to npm registry.
6161
npm install @nicelabs/proposal-arraybuffer-equals --registry https://npm.septs.me
6262
```
6363

64-
## `ArrayBuffer.isEquals`
64+
## `ArrayBuffer.isEqual`
6565

66-
To do this, we propose a new method, `ArrayBuffer.isEquals(a, b)`, which compare two array buffer is equality (bit-wise)
66+
To do this, we propose a new method, `ArrayBuffer.isEqual(a, b)`, which compare two array buffer is equality (bit-wise)
6767

6868
```typescript
6969
// returns false
70-
ArrayBuffer.isEquals(Uint8Array.of(0).buffer, undefined);
70+
ArrayBuffer.isEqual(Uint8Array.of(0).buffer, undefined);
7171
// returns false
72-
ArrayBuffer.isEquals(Uint8Array.of(0).buffer, null);
72+
ArrayBuffer.isEqual(Uint8Array.of(0).buffer, null);
7373
// returns false
74-
ArrayBuffer.isEquals(Uint8Array.of(0).buffer, Uint8Array.of(0, 1).buffer);
74+
ArrayBuffer.isEqual(Uint8Array.of(0).buffer, Uint8Array.of(0, 1).buffer);
7575
// returns true
76-
ArrayBuffer.isEquals(Uint8Array.of(0).buffer, Uint8Array.of(0).buffer);
76+
ArrayBuffer.isEqual(Uint8Array.of(0).buffer, Uint8Array.of(0).buffer);
7777
// returns true
78-
ArrayBuffer.isEquals(
78+
ArrayBuffer.isEqual(
7979
Uint32Array.from([Number.MAX_SAFE_INTEGER]).buffer,
8080
Uint8Array.of(255, 255, 255, 255).buffer,
8181
);

packages/polyfill/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export function isEquals(
1+
export function isEqual(
22
a: ArrayBuffer | null | undefined,
33
b: ArrayBuffer | null | undefined,
44
): boolean {

packages/polyfill/src/polyfill-declare.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
interface ArrayBufferConstructor {
2-
isEquals(
2+
isEqual(
33
a: ArrayBuffer | null | undefined,
44
b: ArrayBuffer | null | undefined,
55
): boolean;

packages/polyfill/src/polyfill.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/// <reference path="./polyfill-declare.ts" />
2-
import { isEquals } from './index';
2+
import { isEqual } from './index';
33

4-
Object.defineProperty(ArrayBuffer, 'isEquals', {
4+
Object.defineProperty(ArrayBuffer, 'isEqual', {
55
enumerable: false,
66
writable: true,
77
configurable: true,
8-
value: isEquals,
8+
value: isEqual,
99
});

0 commit comments

Comments
 (0)