Skip to content

Commit 036aa91

Browse files
authored
Python3.8 (ydataai#356)
* Add Python 3.8 to Travis * Change Pyarrow to Fastparquest backend for tests. * Update unit test with fastparquet Co-authored-by: Gábor Lipták
1 parent 2144c4d commit 036aa91

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
sudo: required
12
dist: bionic
23
language: python
34
cache:
@@ -9,6 +10,7 @@ python:
910
- "3.5"
1011
- "3.6"
1112
- "3.7"
13+
- "3.8"
1214

1315
env:
1416
- TEST=unit

requirements-test.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ codecov
44
pytest-cov
55
pytest-black
66
nbval
7-
pyarrow
7+
fastparquet==0.3.2
88
flake8

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
# Could be optional
4242
"missingno==0.4.2",
4343
"phik==0.9.8",
44-
"astropy>=3.2.3", # preferred 4.0
44+
"astropy>=3.2.3", # preferred 4.0
4545
],
4646
extras_require={
4747
"notebook": ["jupyter-client==5.3.4", "jupyter-core==4.6.1", "ipywidgets"],

tests/issues/test_issue147.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def test_issue147(get_data_file):
1313
"https://github.com/Teradata/kylo/raw/master/samples/sample-data/parquet/userdata2.parquet",
1414
)
1515

16-
df = pd.read_parquet(str(file_name), engine="pyarrow")
16+
df = pd.read_parquet(str(file_name), engine="fastparquet")
1717
report = ProfileReport(df, title="PyArrow with Pandas Parquet Backend")
1818
html = report.to_html()
1919
assert type(html) == str

tests/unit/test_utils.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ def test_read_pandas_parquet():
1111
with pytest.raises(OSError) as e:
1212
read_pandas(p)
1313

14-
assert str(e.value) == "Passed non-file path: dataframe.parquet"
14+
assert str(e.value) in [
15+
# pyarrow
16+
"Passed non-file path: dataframe.parquet",
17+
# fastparquet
18+
"[Errno 2] No such file or directory: 'dataframe.parquet'",
19+
]
1520

1621

1722
def test_read_pandas_csv():

0 commit comments

Comments
 (0)