@@ -1698,7 +1698,7 @@ or refactoring an existing one.
1698
1698
1699
1699
** Bad:**
1700
1700
``` javascript
1701
- const assert = require ( ' assert' ) ;
1701
+ import assert from ' assert' ;
1702
1702
1703
1703
describe (' MakeMomentJSGreatAgain' , () => {
1704
1704
it (' handles date boundaries' , () => {
@@ -1721,7 +1721,7 @@ describe('MakeMomentJSGreatAgain', () => {
1721
1721
1722
1722
** Good:**
1723
1723
``` javascript
1724
- const assert = require ( ' assert' ) ;
1724
+ import assert from ' assert' ;
1725
1725
1726
1726
describe (' MakeMomentJSGreatAgain' , () => {
1727
1727
it (' handles 30-day months' , () => {
@@ -1752,11 +1752,14 @@ Promises are a built-in global type. Use them!
1752
1752
1753
1753
** Bad:**
1754
1754
``` javascript
1755
- require (' request' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
1755
+ import { get } from ' request' ;
1756
+ import { writeFile } from ' fs' ;
1757
+
1758
+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
1756
1759
if (requestErr) {
1757
1760
console .error (requestErr);
1758
1761
} else {
1759
- require ( ' fs ' ). writeFile (' article.html' , response .body , (writeErr ) => {
1762
+ writeFile (' article.html' , response .body , (writeErr ) => {
1760
1763
if (writeErr) {
1761
1764
console .error (writeErr);
1762
1765
} else {
@@ -1770,9 +1773,12 @@ require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (req
1770
1773
1771
1774
** Good:**
1772
1775
``` javascript
1773
- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1776
+ import { get } from ' request' ;
1777
+ import { writeFile } from ' fs' ;
1778
+
1779
+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1774
1780
.then ((response ) => {
1775
- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1781
+ return writeFile (' article.html' , response);
1776
1782
})
1777
1783
.then (() => {
1778
1784
console .log (' File written' );
@@ -1793,9 +1799,12 @@ today!
1793
1799
1794
1800
** Bad:**
1795
1801
``` javascript
1796
- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1802
+ import { get } from ' request-promise' ;
1803
+ import { writeFile } from ' fs-promise' ;
1804
+
1805
+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1797
1806
.then ((response ) => {
1798
- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1807
+ return writeFile (' article.html' , response);
1799
1808
})
1800
1809
.then (() => {
1801
1810
console .log (' File written' );
@@ -1808,10 +1817,13 @@ require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Marti
1808
1817
1809
1818
** Good:**
1810
1819
``` javascript
1820
+ import { get } from ' request-promise' ;
1821
+ import { writeFile } from ' fs-promise' ;
1822
+
1811
1823
async function getCleanCodeArticle () {
1812
1824
try {
1813
- const response = await require ( ' request-promise ' ). get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1814
- await require ( ' fs-promise ' ). writeFile (' article.html' , response);
1825
+ const response = await get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1826
+ await writeFile (' article.html' , response);
1815
1827
console .log (' File written' );
1816
1828
} catch (err) {
1817
1829
console .error (err);
0 commit comments