Skip to content

Commit f20b3e4

Browse files
committed
Review code & publish new version
1 parent c5162d3 commit f20b3e4

File tree

8 files changed

+29
-17
lines changed

8 files changed

+29
-17
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,7 @@ export class TreeviewConfig {
9393
# [2.0.5](https://www.npmjs.com/package/ngx-treeview) (2018-03-19)
9494
### Security:
9595
* Update NPM packages to fix security problem from "zkat / ssri".
96+
97+
# [2.0.6](https://www.npmjs.com/package/ngx-treeview) (2018-04-09)
98+
### Enhancement:
99+
* Add event filterChange.

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ export class AppModule {
5858
<ngx-treeview
5959
[config]="config"
6060
[items]="items"
61-
(selectedChange)="onSelectedChange($event)">
61+
(selectedChange)="onSelectedChange($event)"
62+
(filterChange)="onFilterChange($event)">
6263
</ngx-treeview>
6364
```
6465

@@ -68,7 +69,8 @@ export class AppModule {
6869
[buttonClass]="buttonClass"
6970
[config]="config"
7071
[items]="items"
71-
(selectedChange)="onSelectedChange($event)">
72+
(selectedChange)="onSelectedChange($event)"
73+
(filterChange)="onFilterChange($event)">
7274
</ngx-dropdown-treeview>
7375
```
7476

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-treeview",
3-
"version": "2.0.5",
3+
"version": "2.0.6",
44
"license": "MIT",
55
"description": "An Angular treeview component with checkbox",
66
"scripts": {

src/demo/book/book.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ <h3>Components (
4848
<label>
4949
<strong>ngx-treeview</strong>
5050
</label>
51-
<ngx-treeview [config]="config" [items]="items" (filteredChange)="onFilterChanged($event)" (selectedChange)="values = $event">
51+
<ngx-treeview [config]="config" [items]="items" (filterChange)="onFilterChange($event)" (selectedChange)="values = $event">
5252
</ngx-treeview>
5353
</div>
5454
</div>
@@ -69,7 +69,7 @@ <h3>Components (
6969
</select>
7070
</div>
7171
<ngx-dropdown-treeview [config]="config" [items]="items" [buttonClass]="buttonClass" (selectedChange)="values = $event" [disabled]="!dropdownEnabled"
72-
[ngxDisabledOnSelector]="'button.dropdown-toggle'">
72+
[ngxDisabledOnSelector]="'button.dropdown-toggle'" (filterChange)="onFilterChange($event)">
7373
</ngx-dropdown-treeview>
7474
</div>
7575
</div>

src/demo/book/book.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class BookComponent implements OnInit {
4141
this.items = this.service.getBooks();
4242
}
4343

44-
onFilterChanged(value: string) {
44+
onFilterChange(value: string) {
4545
console.log('filter:', value);
4646
}
4747
}
Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
<div class="dropdown" ngxDropdown>
2-
<button class="btn" [ngClass]="buttonClass" type="button" role="button" ngxDropdownToggle>
3-
{{getText()}}
4-
</button>
5-
<div ngxDropdownMenu aria-labelledby="dropdownMenu" (click)="$event.stopPropagation()">
6-
<div class="dropdown-container">
7-
<ngx-treeview [config]="config" [headerTemplate]="headerTemplate" [items]="items" [itemTemplate]="itemTemplate" (selectedChange)="onSelectedChange($event)">
8-
</ngx-treeview>
9-
</div>
2+
<button class="btn" [ngClass]="buttonClass" type="button" role="button" ngxDropdownToggle>
3+
{{getText()}}
4+
</button>
5+
<div ngxDropdownMenu aria-labelledby="dropdownMenu" (click)="$event.stopPropagation()">
6+
<div class="dropdown-container">
7+
<ngx-treeview [config]="config" [headerTemplate]="headerTemplate" [items]="items" [itemTemplate]="itemTemplate" (selectedChange)="onSelectedChange($event)"
8+
(filterChange)="onFilterChange($event)">
9+
</ngx-treeview>
1010
</div>
11-
</div>
11+
</div>
12+
</div>

src/lib/dropdown-treeview.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export class DropdownTreeviewComponent {
1919
@Input() items: TreeviewItem[];
2020
@Input() config: TreeviewConfig;
2121
@Output() selectedChange = new EventEmitter<any[]>(true);
22+
@Output() filterChange = new EventEmitter<string>();
2223
@ViewChild(TreeviewComponent) treeviewComponent: TreeviewComponent;
2324
@ViewChild(DropdownDirective) dropdownDirective: DropdownDirective;
2425

@@ -36,4 +37,8 @@ export class DropdownTreeviewComponent {
3637
onSelectedChange(values: any[]) {
3738
this.selectedChange.emit(values);
3839
}
40+
41+
onFilterChange(text: string) {
42+
this.filterChange.emit(text);
43+
}
3944
}

src/lib/treeview.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class TreeviewComponent implements OnChanges {
5252
@Input() items: TreeviewItem[];
5353
@Input() config: TreeviewConfig;
5454
@Output() selectedChange = new EventEmitter<any[]>();
55-
@Output() filteredChange = new EventEmitter<string>();
55+
@Output() filterChange = new EventEmitter<string>();
5656
headerTemplateContext: TreeviewHeaderTemplateContext;
5757
allItem: TreeviewItem;
5858
filterText = '';
@@ -96,7 +96,7 @@ export class TreeviewComponent implements OnChanges {
9696

9797
onFilterTextChange(text: string) {
9898
this.filterText = text;
99-
this.filteredChange.emit(text);
99+
this.filterChange.emit(text);
100100
this.updateFilterItems();
101101
}
102102

0 commit comments

Comments
 (0)