Skip to content

Commit 2f23645

Browse files
committed
Fixed equals for Integers and changed structure of Result objects
1 parent 2c435d6 commit 2f23645

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/v1/integer.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* See the License for the specific language governing permissions and
1717
* limitations under the License.
1818
*/
19-
19+
2020
// 64-bit Integer library, originally from Long.js by dcodeIO
2121
// https://github.com/dcodeIO/Long.js
2222
// License Apache 2
@@ -94,7 +94,7 @@ class Integer {
9494
if (this.isZero())
9595
return '0';
9696
var rem;
97-
if (this.isNegative()) {
97+
if (this.isNegative()) {
9898
if (this.equals(Integer.MIN_VALUE)) {
9999
// We need to change the Integer value before it can be negated, so we remove
100100
// the bottom-most digit in this base and then recurse to do the rest.
@@ -162,7 +162,7 @@ class Integer {
162162
*/
163163
isZero() {
164164
return this.high === 0 && this.low === 0;
165-
}
165+
}
166166

167167
/**
168168
* Tests if this Integer's value is negative.
@@ -205,8 +205,6 @@ class Integer {
205205
equals(other) {
206206
if (!Integer.isInteger(other))
207207
other = Integer.fromValue(other);
208-
if ((this.high >>> 31) === 1 && (other.high >>> 31) === 1)
209-
return false;
210208
return this.high === other.high && this.low === other.low;
211209
}
212210

@@ -821,4 +819,4 @@ export default {
821819
Integer,
822820
int,
823821
isInt
824-
}
822+
}

src/v1/result.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ class Result {
5454
let observer = {
5555
onNext: (record) => { records.push(record); },
5656
onCompleted: (summary) => {
57-
records.summary = summary;
58-
resolve(records);
57+
resolve({records, summary});
5958
},
6059
onError: (error) => { reject(error); }
6160
};

0 commit comments

Comments
 (0)