Commits on Nov 17, 2025

1. loading: More extension loading cleanup (#60146) …

   In #59863, I removed a special case that allowed extensions to be
   identified cross-environment. As it turns out, `locate_package` has a
   similar special case, except this one is even weirder (because it will
   definitely break if any package other than the intended base package is
   found).
   
   However, it turns out that removing this special case breaks stdlib
   precompilation. Why you ask? Well, when we precompile stdlibs we set the
   LOAD_PATH to `@stdlib:$(pwd)/stdlib` and then run the precompile
   function (which calls locate_package directly). Note that `@stdlib` is
   an implicit env that we symlink together, while `$(pwd)/stdlib` is an
   explicit env with Project and Manifest. However, these projects and
   manifests are somewhat malformed, because we don't actually have the
   stdlibs in our depot, so they cannot be used for loading.
   
   What's happening here is that it turns out we had a separate bug where
   we cannot properly load extensions from implicit environments unless the
   parent package has previously been loaded. This is usually the case
   (because extensions by definitions have their parent packages loaded),
   but is not the case during an explicit precompile.
   
   The tangled setup previously described found `Statistics` in the first
   environment, then found Statistics' SparseArrayExt in the second
   environemnt, which then computed the extension path by looking up
   `Statistics` in the first environment again.
   
   With loading properly fixed to find extensions in implicit environments
   (which is painful since we need to scan each project.toml in each
   directory), everything goes through and we find all the packages and the
   appropriate extensions in the implicit environment.
   
   I don't think any of this was ever intentionally designed this way but
   just happened to be a combination of bugs covering for each other.
   
   I also don't think that this fallback case will actually trigger in
   practice although it does of course trigger when looking up any package
   that is not actually present in the environment.
   
   As such, it is advisable to avoid large implicit environments at the
   start of the loadpath. `@stdlib` is last in the default setup and our
   other environments are explicit, so again I don't forsee this to happen
   too often in practice, but we might want to consider making `@stdlib` an
   explicit environemnt also to explicitly record everything.

   

   Keno authored Nov 17, 2025
   Configuration menu

   • View commit details
   • Copy full SHA for 19d07d2
   • Browse repository at this point

   Copy the full SHA

   19d07d2 View commit details

   Browse the repository at this point in the history