-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fixes complex range broadcasting with another range #43887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes complex range broadcasting with another range #43887
Conversation
|
How is it we end up attempting to create a TwicePrecision{Complex} instead of a Complex{TwicePrecision}? Is this because we refused to make TwicePrecision a Number? |
|
I have no idea. In the TwicePrecision code there is nothing related to complex numbers, so I think it works because of julia magic, until it gets to methods that specifically use Also this fix needs a change, because when building, when it reaches |
|
Is it possible just to make sure complex numbers are never used? |
|
I suspect this has the same problem as #55113 — it successfully constructs the object but will perform erroneous arithmetic (in particular division) with the resulting thing. |
Fixes #32792.
To fix it I had to add
precisionto complex types, I can split it into two different PRs if necessary