improve nongeneric methods of Base.rest, Base.indexed_iterate
#59549
+58
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow non-`Int` in dispatch for the second argument (iteration state), but `typeassert` `Int` in the method body. This improves abstract inference because the compiler can know the second argument must be `Int` to avoid a throw, when previously such a call would have dispatched to the generic method. * `Base.rest`: unify the methods for `Array` and `SimpleVector`, also adding in `Memory`. * `Base.indexed_iterate`: add `Memory` to the method for `Array`, as with `Base.rest`.
nsajko
added
arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow non-
Intin dispatch for the second argument (iteration state), buttypeassertIntin the method body. This improves abstract inference because the compiler can know the second argument must beIntto avoid a throw, when previously such a call would have dispatched to the generic method.Base.rest: unify the methods forArrayandSimpleVector, also adding inMemory.Base.indexed_iterate: addMemoryto the method forArray, as withBase.rest.