Skip to content

Commit 66269f4

Browse files
authored
🐛Find-LocalModule min comparison using wrong logic (#91)
Fixes #88
1 parent de426e2 commit 66269f4

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

ModuleFast.psm1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1816,11 +1816,11 @@ function Find-LocalModule {
18161816

18171817
#We can fast filter items that are below the lower bound, we dont need to read these manifests
18181818
if ($ModuleSpec.Min) {
1819-
#HACK: Nuget does not correctly convert major.minor.build versions.
1819+
#HACK: Nuget does not correctly convert major.minor.build versions
18201820
[version]$originalBaseVersion = ($modulespec.Min.OriginalVersion -split '-')[0]
18211821
[Version]$minVersion = $originalBaseVersion.Revision -eq -1 ? $originalBaseVersion : $ModuleSpec.Min.Version
1822-
if ($minVersion -lt $ModuleSpec.Min.OriginalVersion) {
1823-
Write-Debug "${ModuleSpec}: Skipping $folder - below the lower bound"
1822+
if ($version -lt $minVersion) {
1823+
Write-Debug "${ModuleSpec}: Skipping $folder - $version is below the lower bound of $minVersion"
18241824
return
18251825
}
18261826
}

ModuleFast.tests.ps1

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,14 @@ Describe 'Get-ModuleFastPlan' -Tag 'E2E' {
259259
}
260260
ModuleName = 'PrereleaseTest'
261261
},
262+
@{
263+
Spec = 'PrereleaseTest>=0.0.1-prerelease'
264+
Check = {
265+
$actual.Name | Should -Be 'PrereleaseTest'
266+
$actual.ModuleVersion | Should -Be '0.0.2-prerelease'
267+
}
268+
ModuleName = 'PrereleaseTest'
269+
},
262270
@{
263271
Spec = 'PrereleaseTest:*'
264272
ModuleName = 'PrereleaseTest'

0 commit comments

Comments
 (0)