Fix memleaks in Tree.EntryBy(Name/Path/Index), fixes libgit2#313

AaronO · AaronO · commit f503d918aa62 · 2017-02-24T22:55:14.000+01:00
diff --git a/tree.go b/tree.go
@@ -51,6 +51,7 @@ func (t Tree) EntryByName(filename string) *TreeEntry {
 	if entry == nil {
 		return nil
 	}
+	defer C.git_tree_entry_free(entry)
 
 	return newTreeEntry(entry)
 }
@@ -69,6 +70,7 @@ func (t Tree) EntryByPath(path string) (*TreeEntry, error) {
 	if ret < 0 {
 		return nil, MakeGitError(ret)
 	}
+	defer C.git_tree_entry_free(entry)
 
 	return newTreeEntry(entry), nil
 }
@@ -78,6 +80,7 @@ func (t Tree) EntryByIndex(index uint64) *TreeEntry {
 	if entry == nil {
 		return nil
 	}
+	defer C.git_tree_entry_free(entry)
 
 	return newTreeEntry(entry)
 }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ func (t Tree) EntryByName(filename string) *TreeEntry {`
`51`	`51`	`if entry == nil {`
`52`	`52`	`return nil`
`53`	`53`	`}`
	`54`	`+ defer C.git_tree_entry_free(entry)`
`54`	`55`
`55`	`56`	`return newTreeEntry(entry)`
`56`	`57`	`}`
`@@ -69,6 +70,7 @@ func (t Tree) EntryByPath(path string) (*TreeEntry, error) {`
`69`	`70`	`if ret < 0 {`
`70`	`71`	`return nil, MakeGitError(ret)`
`71`	`72`	`}`
	`73`	`+ defer C.git_tree_entry_free(entry)`
`72`	`74`
`73`	`75`	`return newTreeEntry(entry), nil`
`74`	`76`	`}`
`@@ -78,6 +80,7 @@ func (t Tree) EntryByIndex(index uint64) *TreeEntry {`
`78`	`80`	`if entry == nil {`
`79`	`81`	`return nil`
`80`	`82`	`}`
	`83`	`+ defer C.git_tree_entry_free(entry)`
`81`	`84`
`82`	`85`	`return newTreeEntry(entry)`
`83`	`86`	`}`