Skip to content

Commit f9df45b

Browse files
committed
Add a TODO
1 parent 07c5a56 commit f9df45b

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

core/commonJs/src/Instant.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public actual class Instant internal constructor(internal val value: jtInstant)
7373
if (epochMilliseconds > 0) MAX else MIN
7474
}
7575

76+
// TODO: implement a custom parser to 1) help DCE get rid of the formatting machinery 2) move Instant to stdlib
7677
public actual fun parse(input: CharSequence, format: DateTimeFormat<DateTimeComponents>): Instant = try {
7778
// This format is not supported properly by Joda-Time, so we can't delegate to it.
7879
format.parse(input).toInstantUsingOffset()

core/jvm/src/Instant.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public actual class Instant internal constructor(internal val value: jtInstant)
6565
public actual fun fromEpochMilliseconds(epochMilliseconds: Long): Instant =
6666
Instant(jtInstant.ofEpochMilli(epochMilliseconds))
6767

68+
// TODO: implement a custom parser to 1) help DCE get rid of the formatting machinery 2) move Instant to stdlib
6869
public actual fun parse(input: CharSequence, format: DateTimeFormat<DateTimeComponents>): Instant = try {
6970
/**
7071
* Can't use built-in Java Time's handling of `Instant.parse` because it supports 24:00:00 and

0 commit comments

Comments
 (0)