Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Lambda-NIC/faas-netes
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Lambda-NIC/faas-netes
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: alexellis/fetch-replicas-directly
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on May 16, 2018

  1. Fix 198 to optimize fetching single functions 

    An optimization is introduced to the single replica reader which
means we use "Get" rather than "List" and filtering in memory.
I originally wrote the List/filter approach with the intention of
applying this change later. @imikushin from VMware suggested this
change and raised PR196 - since there were some issues with
process, Kubernetes version used and (lack of) testing I've
implemented the change and done testing for this.

[x] List functions gives correct content-type and list
[x] Individual function queries return the correct data and
content-type
[x] Individual function queries for non-existant functions give
404 when not found

Also tested through the OpenFaaS UI including testing that
there was no regression for the readiness feature.

Signed-off-by: Alex Ellis (VMware) <[email protected]>
    @alexellis
    alexellis committed May 16, 2018
    Configuration menu
    Copy the full SHA
    1b08d7a View commit details
    Browse the repository at this point in the history
Loading