Skip to content

feat: Any chance for switch session with language bind with? #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seognil opened this issue Jun 6, 2019 · 4 comments
Open

feat: Any chance for switch session with language bind with? #341

seognil opened this issue Jun 6, 2019 · 4 comments

Comments

@seognil
Copy link

seognil commented Jun 6, 2019

🚀 Feature Proposal

Thanks for the work! 😄

I thought it would be great if it could has multi language session switch feature.

I saw there was already a session feature, but I'm confused with the configuration,
(I could not found much detailed description in readme... 🤔)

Is there a separate config file like .leetcoderc? or only in vscode's settings.json

(Maybe a local leetcode-progress json structure to record, even better)(For self analyze propose...)

Motivation

Because I want to practice with multi languages 🙋‍♀️

@jdneo
Copy link
Member

jdneo commented Jun 8, 2019

Hi @seognil,

Would you mind to describe more about the multi-language session? Just not quite get your point. 😄

@jdneo jdneo added the need more info Further information is requested label Jun 8, 2019
@seognil
Copy link
Author

seognil commented Jun 8, 2019

(Oh, I get it now, the session feature is from leetcode.com, I can manage that on the website.)


The remaining problem is, language
I mean programing language (or defaultLanguage from the api),

I thought it could be better if each session has its own defaultLanguage config in local.
(I only found the global leetcode.defaultLanguage in settings.json in vscode now)

For example:

// leetcode-training-folder/.vscode/settings.json
{
  "leetcode.sessions": {
    "js (session label)": {
      "defaultLanguage": "javascript",
      "outputFolder": "./js/"
    },
    "cpp": {
      "defaultLanguage": "cpp",
      "outputFolder": "./cpp/"
    },
    "python": {
      "defaultLanguage": "python",
      "outputFolder": "./py/"
    }
  }
}

How about that 😄

@no-response no-response bot removed the need more info Further information is requested label Jun 8, 2019
@jdneo
Copy link
Member

jdneo commented Jun 8, 2019

Switch session is supported in the extension, see: https://github.com/jdneo/vscode-leetcode#manage-session

About your proposed setting schema, I'm not sure if this is a common requirement from others. So I tend to leave it open for a while to see if there is any feedback from other users.

Thank you.

@seognil seognil changed the title feat: Any chance for multi language session switch? feat: Any chance for switch session with language bind with? Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@seognil @jdneo and others