Skip to content

Cannot bind a keyboard shortcut to 'ShowTopVotedSolution' #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdneo opened this issue Jul 16, 2019 · 1 comment · Fixed by #399
Closed

Cannot bind a keyboard shortcut to 'ShowTopVotedSolution' #368

jdneo opened this issue Jul 16, 2019 · 1 comment · Fixed by #399
Labels
bug Something isn't working
Milestone
0.15.3

Comments

@jdneo
Copy link
Member

jdneo commented Jul 16, 2019

🐛 Bug Report

It will show Invalid input to fetch the solution data

Solution

We need to handle the undefined situation in https://github.com/jdneo/vscode-leetcode/blob/master/src/commands/show.ts#L73
@jdneo jdneo added the bug Something isn't working label Jul 16, 2019
@jdneo jdneo added this to the 0.15.3 milestone Jul 16, 2019
@jdneo jdneo mentioned this issue Aug 24, 2019
Merged
@ghost
Copy link

ghost commented Aug 13, 2023

issue is not fixed, im still experiencing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.15.3
Development

Successfully merging a pull request may close this issue.

fix: Can trigger showTopVotedSolution from keyboard shortcut LeetCode-OpenSource/vscode-leetcode
1 participant
@jdneo