Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Li-Bot/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 12 files changed
  • 3 contributors

Commits on Sep 21, 2020

  1. Update to recommended settings (Xcode 12)

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    61f0cd5 View commit details
    Browse the repository at this point in the history

  2. Replace #file with the new #filePath

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f00d440 View commit details
    Browse the repository at this point in the history

  3. Update CI config to use Xcode 12

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9bdb08b View commit details
    Browse the repository at this point in the history

  4. Update README

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ac0f5c1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #35 from essentialdevelopercom/xcode12 

    Update to Xcode 12
    @mapostolakis
    mapostolakis authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a8ca4b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Added client call in RemoteFeedLoader to complete load request.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    deba60e View commit details
    Browse the repository at this point in the history

  2. Added returns connectivity error when HTTPClient fails.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e74f185 View commit details
    Browse the repository at this point in the history

  3. Added returns invalid data when HTTPClient returns non 200 status code.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e38781f View commit details
    Browse the repository at this point in the history

  4. Added named tuple parameters of HTTPClient successful response

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    fe2e653 View commit details
    Browse the repository at this point in the history

  5. Added domain API response structures and returns invalid data when HT… 

    …TPClient returns invalid JSON.
    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    4a578a3 View commit details
    Browse the repository at this point in the history

  6. Refactored RemoteFeedLoader load success response.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    1035e8e View commit details
    Browse the repository at this point in the history

  7. Added Image mapping from API response to domain objects.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    d2b53b4 View commit details
    Browse the repository at this point in the history

  8. Added returns no result if RemoteFeedLoader has been deallocated whil… 

    …e HTTPClient returns response.
    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    d6d2282 View commit details
    Browse the repository at this point in the history

  9. Cleaned FeedImagesMapper decoding logic.

    @Li-Bot
    Li-Bot committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8509d8b View commit details
    Browse the repository at this point in the history
Loading