Skip to content

Commit 6f41020

Browse files
authored
Enable RS1026 (Enable concurrent execution) (dotnet#4801)
1 parent 5f5869b commit 6f41020

8 files changed

+13
-3
lines changed

.editorconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ dotnet_diagnostic.VSTHRD103.severity = none
1313
# VSTHRD200: Use "Async" suffix for async methods
1414
dotnet_diagnostic.VSTHRD200.severity = none
1515

16-
# RS1026: Enable concurrent execution
17-
dotnet_diagnostic.RS1026.severity = none
18-
1916
[test/**/*.cs]
2017

2118
# MSML_GeneralName: This name should be PascalCased

tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public override void Initialize(AnalysisContext context)
4040
{
4141
// This analyzer reports violations in all code (including generated code)
4242
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
43+
context.EnableConcurrentExecution();
4344

4445
context.RegisterSemanticModelAction(Analyze);
4546
}

tools-local/Microsoft.ML.InternalCodeAnalyzer/ContractsCheckAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ internal static class DecodeMessageWithLoadContextDiagnostic
8888
public override void Initialize(AnalysisContext context)
8989
{
9090
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
91+
context.EnableConcurrentExecution();
92+
9193
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.InvocationExpression);
9294
}
9395

tools-local/Microsoft.ML.InternalCodeAnalyzer/InstanceInitializerAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ public sealed class InstanceInitializerAnalyzer : DiagnosticAnalyzer
3131
public override void Initialize(AnalysisContext context)
3232
{
3333
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
34+
context.EnableConcurrentExecution();
35+
3436
context.RegisterSymbolAction(AnalyzeField, SymbolKind.Field);
3537
context.RegisterSymbolAction(AnalyzeProperty, SymbolKind.Property);
3638
}

tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ internal static class GeneralName
7474
public override void Initialize(AnalysisContext context)
7575
{
7676
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
77+
context.EnableConcurrentExecution();
78+
7779
context.RegisterSyntaxNodeAction(AnalyzeField, SyntaxKind.FieldDeclaration);
7880
context.RegisterSyntaxNodeAction(AnalyzeField, SyntaxKind.EventFieldDeclaration);
7981
context.RegisterSyntaxNodeAction(AnalyzeClass, SyntaxKind.ClassDeclaration);

tools-local/Microsoft.ML.InternalCodeAnalyzer/ParameterVariableNameAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ public sealed class ParameterVariableNameAnalyzer : DiagnosticAnalyzer
3232
public override void Initialize(AnalysisContext context)
3333
{
3434
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
35+
context.EnableConcurrentExecution();
36+
3537
context.RegisterSyntaxNodeAction(AnalyzeParameter, SyntaxKind.Parameter);
3638
context.RegisterSyntaxNodeAction(AnalyzeLocal, SyntaxKind.LocalDeclarationStatement);
3739
}

tools-local/Microsoft.ML.InternalCodeAnalyzer/SingleVariableDeclarationAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ public sealed class SingleVariableDeclarationAnalyzer : DiagnosticAnalyzer
3232
public override void Initialize(AnalysisContext context)
3333
{
3434
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
35+
context.EnableConcurrentExecution();
36+
3537
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.VariableDeclaration);
3638
}
3739

tools-local/Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ public sealed class TypeParamNameAnalyzer : DiagnosticAnalyzer
3131
public override void Initialize(AnalysisContext context)
3232
{
3333
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
34+
context.EnableConcurrentExecution();
35+
3436
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.TypeParameter);
3537
}
3638

0 commit comments

Comments
 (0)