Fix data[].ext.taxonomyname NPE (prebid#1173)

rpanchyk · web-flow · commit 19620f427e28 · 2021-03-01T17:11:47.000+02:00
diff --git a/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java b/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
@@ -1003,11 +1003,9 @@ private void enrichWithIabAttribute(ObjectNode target, List<Data> data) {
     }
 
     private boolean containsIabTaxonomyName(ObjectNode ext) {
-        final JsonNode taxonomyname = ext.get("taxonomyname");
-        if (taxonomyname != null && taxonomyname.isTextual()) {
-            return StringUtils.containsIgnoreCase(taxonomyname.textValue(), "iab");
-        }
-        return false;
+        final JsonNode taxonomyName = ext != null ? ext.get("taxonomyname") : null;
+        return taxonomyName != null && taxonomyName.isTextual()
+                && StringUtils.containsIgnoreCase(taxonomyName.textValue(), "iab");
     }
 
     private static String extractLiverampId(Map<String, List<ExtUserEid>> sourceToUserEidExt) {

Original file line number	Diff line number	Diff line change
`@@ -1003,11 +1003,9 @@ private void enrichWithIabAttribute(ObjectNode target, List<Data> data) {`
`1003`	`1003`	`}`
`1004`	`1004`
`1005`	`1005`	`private boolean containsIabTaxonomyName(ObjectNode ext) {`
`1006`		`- final JsonNode taxonomyname = ext.get("taxonomyname");`
`1007`		`- if (taxonomyname != null && taxonomyname.isTextual()) {`
`1008`		`- return StringUtils.containsIgnoreCase(taxonomyname.textValue(), "iab");`
`1009`		`- }`
`1010`		`- return false;`
	`1006`	`+ final JsonNode taxonomyName = ext != null ? ext.get("taxonomyname") : null;`
	`1007`	`+ return taxonomyName != null && taxonomyName.isTextual()`
	`1008`	`+ && StringUtils.containsIgnoreCase(taxonomyName.textValue(), "iab");`
`1011`	`1009`	`}`
`1012`	`1010`
`1013`	`1011`	`private static String extractLiverampId(Map<String, List<ExtUserEid>> sourceToUserEidExt) {`