Skip to content

Commit 3092bd4

Browse files
committed
Finish making master changes compatible with feature/new-context-page-browser's
1 parent 4f0f4dc commit 3092bd4

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

atest/test/01_Browser_Management/playwright_state.robot

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ New Browser does not open a page
2323
New Browser does not create a context
2424
# Use Switch context to test that no context exists here
2525
Pass Execution Not Implemented yet
26-
[Teardown]
26+
[Teardown] Pass Execution Not Implemented yet
2727
Switch Context
2828

2929
New Context does not open a page
@@ -32,14 +32,14 @@ New Context does not open a page
3232

3333
Switch Browser
3434
Pass Execution Not Implemented yet
35-
[Teardown]
35+
[Teardown] Pass Execution Not Implemented yet
3636
New Browser chromium
3737
New Browser firefox
3838
Switch Browser
3939

4040
Switch Context
4141
Pass Execution Not Implemented yet
42-
[Teardown]
42+
[Teardown] Pass Execution Not Implemented yet
4343
New Context
4444
New Context
4545
Switch Context

atest/test/04_frames/frames.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
*** Settings ***
22
Resource imports.resource
3-
Suite Setup Open Browser ${FRAMES URL} browser=${BROWSER} headless=${HEADLESS}
3+
Suite Setup Open Browser To Frame Page
44
Suite Teardown Close Browser
55

66
*** Test Cases ***

atest/test/keywords.resource

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ Resource variables.resource
77
${PLAYWRIGHT TIMEOUT} 1 second
88

99
*** Keywords ***
10+
Open Browser To Frame Page
11+
New Browser ${BROWSER} headless=${HEADLESS}
12+
New Page ${FRAMES URL}
13+
14+
1015
Open Browser To Login Page
1116
New Browser ${BROWSER} headless=${HEADLESS}
1217
New Page ${LOGIN URL}

node/playwright-wrapper/playwirght-util.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export async function waitUntilElementExists<T>(page: Page | undefined, callback
66
}
77

88
export async function invokeOnPage(page: Page | undefined, callback: any, methodName: string, ...args: any[]) {
9-
exists(page, callback, `Tried to do playwirght action '${methodName}', but no open browser.`);
9+
exists(page, callback, `Tried to do playwright action '${methodName}', but no open page.`);
1010
const fn: any = (page as { [key: string]: any })[methodName].bind(page);
1111
try {
1212
return await fn(...args);
@@ -36,7 +36,7 @@ export async function invokeOnPageWithSelector<T>(
3636
selector: string,
3737
...args: any[]
3838
) {
39-
exists(page, callback, `Tried to do playwirght action '${methodName}', but no open browser.`);
39+
exists(page, callback, `Tried to do playwright action '${methodName}', but no open browser.`);
4040
const { elementSelector, fn } = await determineFunctionAndSelector(page, methodName, selector, callback);
4141
try {
4242
return await fn(elementSelector, ...args);

0 commit comments

Comments
 (0)