Skip to content

Commit 4cc7b69

Browse files
karann-msftzivkannkolev92loic-sharma
authored
Apply suggestions from code review
Co-Authored-By: Andy Zivkovic <[email protected]> Co-Authored-By: Nikolche Kolev <[email protected]> Co-Authored-By: Loïc Sharma <[email protected]>
1 parent b0eac4d commit 4cc7b69

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/reference/errors-and-warnings/NU5047.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ f1_keywords:
1717

1818
# Issue
1919

20-
The file that is specified as the package icon has a filesize larger than 1 megabyte (MB). NuGet only allow icons whose filesize is less than 1 MB.
20+
The file that is specified as the package icon is larger than 1 megabyte (MB). NuGet only allows icons whose file size is less than 1 MB.
2121

2222

2323
# Solution
2424

25-
Use an image editor program to edit and downsize the package icon file.
25+
Use an image editor program to reduce the size of the package icon file.

docs/reference/msbuild-targets.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ Note that the `Owners` and `Summary` properties from `.nuspec` are not supported
5555
| RequireLicenseAcceptance | PackageRequireLicenseAcceptance | false | |
5656
| license | PackageLicenseExpression | empty | Corresponds to `<license type="expression">` |
5757
| license | PackageLicenseFile | empty | Corresponds to `<license type="file">`. You may need to explicitly pack the referenced license file. |
58-
| LicenseUrl | PackageLicenseUrl | empty | `PackageLicenseUrl` is being deprecated, use the PackageLicenseExpression or PackageLicenseFile property |
58+
| LicenseUrl | PackageLicenseUrl | empty | `PackageLicenseUrl` is deprecated, use the PackageLicenseExpression or PackageLicenseFile property |
5959
| ProjectUrl | PackageProjectUrl | empty | |
60-
| icon | PackageIcon | empty | You may need to explicitly pack the referenced icon image file.|
61-
| IconUrl | PackageIconUrl | empty | `PackageIconUrl` is being deprecated, use the PackageIcon property |
60+
| Icon | PackageIcon | empty | You may need to explicitly pack the referenced icon image file.|
61+
| IconUrl | PackageIconUrl | empty | `PackageIconUrl` is deprecated, use the PackageIcon property |
6262
| Tags | PackageTags | empty | Tags are semi-colon delimited. |
6363
| ReleaseNotes | PackageReleaseNotes | empty | |
6464
| Repository/Url | RepositoryUrl | empty | Repository URL used to clone or retrieve source code. Example: *https://github.com/NuGet/NuGet.Client.git* |
@@ -221,7 +221,7 @@ When packing a license file, you need to use PackageLicenseFile property to spec
221221

222222
### Packing an icon image file
223223

224-
When packing an icon image file, you need to use PackageIcon property to specify the package path, relative to the root of the package. In addition, you need to make sure that the file is included in the package. Image file size is limited to 1 MB. Supported file formats include JPEG and PNG. We recommend an image resoulution of 64x64.
224+
When packing an icon image file, you need to use PackageIcon property to specify the package path, relative to the root of the package. In addition, you need to make sure that the file is included in the package. Image file size is limited to 1 MB. Supported file formats include JPEG and PNG. We recommend an image resolution of 64x64.
225225

226226
For example:
227227

0 commit comments

Comments
 (0)