Skip to content

Commit 124bfc0

Browse files
committed
Switch profiles to use stackprof, since it merges fibers
1 parent d4901ac commit 124bfc0

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

benchmark/run.rb

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "graphql"
44
require "jazz"
55
require "benchmark/ips"
6-
require "ruby-prof"
6+
require "stackprof"
77
require "memory_profiler"
88
require "graphql/batch"
99

@@ -46,15 +46,11 @@ def self.profile
4646
SCHEMA.execute(document: DOCUMENT)
4747
# CARD_SCHEMA.validate(ABSTRACT_FRAGMENTS)
4848
res = nil
49-
result = RubyProf.profile do
49+
result = StackProf.run(mode: :wall) do
5050
# CARD_SCHEMA.validate(ABSTRACT_FRAGMENTS)
5151
res = SCHEMA.execute(document: DOCUMENT)
5252
end
53-
# printer = RubyProf::FlatPrinter.new(result)
54-
# printer = RubyProf::GraphHtmlPrinter.new(result)
55-
printer = RubyProf::FlatPrinterWithLineNumbers.new(result)
56-
57-
printer.print(STDOUT, {})
53+
StackProf::Report.new(result).print_text
5854
end
5955

6056
# Adapted from https://github.com/rmosolgo/graphql-ruby/issues/861
@@ -67,13 +63,10 @@ def self.profile_large_result
6763
}
6864
end
6965

70-
result = RubyProf.profile do
66+
result = StackProf.run(mode: :wall) do
7167
schema.execute(document: document)
7268
end
73-
printer = RubyProf::FlatPrinter.new(result)
74-
# printer = RubyProf::GraphHtmlPrinter.new(result)
75-
# printer = RubyProf::FlatPrinterWithLineNumbers.new(result)
76-
printer.print(STDOUT, {})
69+
StackProf::Report.new(result).print_text
7770

7871
report = MemoryProfiler.report do
7972
schema.execute(document: document)

graphql.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Gem::Specification.new do |s|
3636
s.add_development_dependency "racc", "~> 1.4"
3737
s.add_development_dependency "rake", "~> 12"
3838
s.add_development_dependency "rubocop", "0.68" # for Ruby 2.2 enforcement
39+
s.add_development_dependency "stackprof"
3940
# required for upgrader
4041
s.add_development_dependency "parser"
4142
# website stuff

0 commit comments

Comments
 (0)