Skip to content

Commit f91a9a7

Browse files
committed
Merge pull request django-haystack#742 from bigjust/simple-backend-score-fix
Simple: removed conflicting score field from raw result objects
2 parents ac6bbfb + 7247f6b commit f91a9a7

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

haystack/backends/simple_backend.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ def search(self, query_string, **kwargs):
7171
hits += len(qs)
7272

7373
for match in qs:
74+
del(match.__dict__['score'])
7475
result = result_class(match._meta.app_label, match._meta.module_name, match.pk, 0, **match.__dict__)
7576
# For efficiency.
7677
result._model = match.__class__

tests/core/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ class MockModel(models.Model):
1212
foo = models.CharField(max_length=255, blank=True)
1313
pub_date = models.DateTimeField(default=datetime.datetime.now)
1414
tag = models.ForeignKey(MockTag)
15-
15+
score = models.CharField(max_length=10, blank=True)
16+
1617
def __unicode__(self):
1718
return self.author
1819

tests/simple_tests/search_indexes.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ class SimpleMockSearchIndex(indexes.SearchIndex, indexes.Indexable):
66
text = indexes.CharField(document=True, use_template=True)
77
name = indexes.CharField(model_attr='author')
88
pub_date = indexes.DateField(model_attr='pub_date')
9-
9+
score = indexes.CharField(model_attr='score')
10+
1011
def get_model(self):
1112
return MockModel

tests/simple_tests/tests/simple_backend.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,7 @@
77
from haystack.utils.loading import UnifiedIndex
88
from core.models import MockModel
99
from core.tests.mocks import MockSearchResult
10-
11-
12-
class SimpleMockSearchIndex(indexes.SearchIndex, indexes.Indexable):
13-
text = indexes.CharField(document=True, use_template=True)
14-
name = indexes.CharField(model_attr='author', faceted=True)
15-
pub_date = indexes.DateField(model_attr='pub_date')
16-
17-
def get_model(self):
18-
return MockModel
10+
from simple_tests.search_indexes import SimpleMockSearchIndex
1911

2012

2113
class SimpleSearchBackendTestCase(TestCase):

0 commit comments

Comments
 (0)