Skip to content

Content jumps after page is loaded #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janoshrubos opened this issue Sep 2, 2021 · 10 comments
Closed

Content jumps after page is loaded #34

janoshrubos opened this issue Sep 2, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@janoshrubos
Copy link
Collaborator

Posted by: @vallemar NativeScript/NativeScript#9302

When you search in the documents: for example Label, if you click on the first option it first takes you to https://docs.nativescript.org/ui-and-styling.html#label and then changes to https://docs.nativescript.org/ui-and-styling.html#frame in my case. Does the same with everything.

It's a bit random, sometimes it leads to the section and sometimes it doesn't. (for me most do not)

@DiySane
Copy link

DiySane commented Oct 4, 2021

May I work on this issue as part of Hacktoberfest?

@DiySane
Copy link

DiySane commented Oct 4, 2021

@janoshrubos kindly assign this issue to me.

@janoshrubos
Copy link
Collaborator Author

@DiySane the source code of the docs and the theme is in a private repo, so unfortunately I couldn't assign it to you

@DiySane
Copy link

DiySane commented Oct 4, 2021

Okay, no problem @janoshrubos . Feel free to tag me for any future issue.

@janoshrubos
Copy link
Collaborator Author

@DiySane sure, will do! thank you very much!

@vallemar
Copy link
Contributor

vallemar commented Nov 3, 2021

Hello @janoshrubos,

I know this is not the highest priority, but is there any progress? It is very annoying to search the documents and always take you somewhere else

@vallemar
Copy link
Contributor

I do not want to be annoying 😅, but I still find these jumps incredibly annoying when doing a search

@rigor789
Copy link
Member

Fixed in 09f11c9

(we are reworking parts of the docs however, but in the meantime this should reduce the issue if not completely fix it)

@vallemar
Copy link
Contributor

Awesome!

@rigor789
Copy link
Member

Noticed a few more cases that aren't handled, but should be vastly better now - also improved our search indexing so quick search should yield more relevant results now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants