Merge pull request rmosolgo#4791 from rmosolgo/fix-variables-with-wrong-type

Fix for when variables are defined as object types

Author: rmosolgo

lib/graphql/query/variables.rb

@@ -26,7 +26,7 @@ def initialize(ctx, ast_variables, provided_variables)
           # - Then, fall back to the default value from the query string
           # If it's still nil, raise an error if it's required.
           variable_type = schema.type_from_ast(ast_variable.type, context: ctx)
-          if variable_type.nil?
+          if variable_type.nil? || !variable_type.unwrap.kind.input?
             # Pass -- it will get handled by a validator
           else
             variable_name = ast_variable.name
@@ -80,12 +80,12 @@ def deep_stringify(val)
         else
           val
         end
-      end    
+      end
 
       def add_max_errors_reached_message
         message = "Too many errors processing variables, max validation error limit reached. Execution aborted"
         validation_result = GraphQL::Query::InputValidationResult.from_problem(message)
-        errors << GraphQL::Query::VariableValidationError.new(nil, nil, nil, validation_result, msg: message) 
+        errors << GraphQL::Query::VariableValidationError.new(nil, nil, nil, validation_result, msg: message)
       end
     end
   end

spec/graphql/query_spec.rb

@@ -591,6 +591,22 @@ def self.after_query(q)
         end
       end
     end
+
+    describe "when given as an object type and accessed in ruby" do
+      it "returns an error to the client and is an empty hash" do
+        result = schema.execute(<<~GRAPHQL)
+        query($ch: Cheese) {
+          __typename
+        }
+        GRAPHQL
+        expected_messages = [
+          "Cheese isn't a valid input type (on $ch)",
+          "Variable $ch is declared by anonymous query but not used",
+        ]
+        assert_equal expected_messages, result["errors"].map { |err| err["message"] }
+        assert_equal({}, result.query.variables.to_h)
+      end
+    end
   end
 
   describe "max_depth" do