HDXDSYS-1785 Output errors last from error handler in HDX Python Utilities (#37)

* Output warnings first

* styling

Author: mcarans

.config/pre-commit-config.yaml

@@ -10,7 +10,7 @@ repos:
         exclude: (test_csv_processing_blanks.csv|test.txt)
       - id: check-ast
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.8.6
+    rev: v0.9.6
     hooks:
       # Run the linter.
       - id: ruff
@@ -19,7 +19,7 @@ repos:
       - id: ruff-format
         args: [--config, .config/ruff.toml]
   - repo: https://github.com/astral-sh/uv-pre-commit
-    rev: 0.5.15
+    rev: 0.6.1
     hooks:
       # Run the pip compile
       - id: pip-compile

pyproject.toml

@@ -107,7 +107,7 @@ run = """
        """
 
 [tool.hatch.envs.hatch-static-analysis]
-dependencies = ["ruff==0.8.6"]
+dependencies = ["ruff==0.9.6"]
 
 [tool.hatch.envs.hatch-static-analysis.scripts]
 format-check = ["ruff format --config .config/ruff.toml --check --diff {args:.}",]

requirements.txt

@@ -8,9 +8,9 @@ attrs==25.1.0
     #   jsonlines
     #   jsonschema
     #   referencing
-beautifulsoup4==4.12.3
+beautifulsoup4==4.13.3
     # via hdx-python-utilities (pyproject.toml)
-certifi==2024.12.14
+certifi==2025.1.31
     # via requests
 cfgv==3.4.0
     # via pre-commit
@@ -20,7 +20,7 @@ charset-normalizer==3.4.1
     # via requests
 click==8.1.8
     # via typer
-coverage==7.6.10
+coverage==7.6.12
     # via pytest-cov
 distlib==0.3.9
     # via virtualenv
@@ -36,9 +36,9 @@ frictionless==5.18.0
     # via hdx-python-utilities (pyproject.toml)
 html5lib==1.1
     # via hdx-python-utilities (pyproject.toml)
-humanize==4.11.0
+humanize==4.12.1
     # via frictionless
-identify==2.6.6
+identify==2.6.7
     # via pre-commit
 idna==3.10
     # via
@@ -159,6 +159,7 @@ typer==0.15.1
     # via frictionless
 typing-extensions==4.12.2
     # via
+    #   beautifulsoup4
     #   frictionless
     #   pydantic
     #   pydantic-core
@@ -170,15 +171,15 @@ urllib3==2.3.0
     # via requests
 validators==0.34.0
     # via frictionless
-virtualenv==20.29.1
+virtualenv==20.29.2
     # via pre-commit
 webencodings==0.5.1
     # via html5lib
 xlrd==2.0.1
     # via hdx-python-utilities (pyproject.toml)
 xlsx2csv==0.8.4
     # via hdx-python-utilities (pyproject.toml)
-xlsxwriter==3.2.1
+xlsxwriter==3.2.2
     # via tableschema-to-template
 xlwt==1.3.0
     # via hdx-python-utilities (pyproject.toml)

src/hdx/utilities/error_handler.py

@@ -151,20 +151,20 @@ def add_multi_valued(
 
     def log(self) -> None:
         """
-        Log errors and warnings by category and sorted
+        Log warnings and errors by category and sorted
 
         Returns:
             None
         """
 
-        for _, errors in self.shared_errors["error"].items():
-            errors = sorted(errors)
-            for error in errors:
-                logger.error(error)
         for _, warnings in self.shared_errors["warning"].items():
             warnings = sorted(warnings)
             for warning in warnings:
                 logger.warning(warning)
+        for _, errors in self.shared_errors["error"].items():
+            errors = sorted(errors)
+            for error in errors:
+                logger.error(error)
 
     def exit_on_error(self) -> None:
         """Exit with a 1 code if there are errors and should_exit_on_error

src/hdx/utilities/text.py

@@ -122,7 +122,7 @@ def remove_string(
     newstring = remove_end_characters(
         newstring, characters_to_remove=end_characters_to_remove
     )
-    return f"{newstring}{string[index + len(toremove):]}"
+    return f"{newstring}{string[index + len(toremove) :]}"
 
 
 def get_words_in_sentence(sentence: str) -> List[str]: