Chore: Revise metadata fetch setup for telemetry (ToolJet#2610)

* revise metadata service for telemetry

* send finish installation metric only on prod

* fix endpoint

* keep fetching metadata with an interval

* fix version check error

* remove ip address on telemetry

Author: akshaysasidrn

frontend/src/App/App.jsx

@@ -34,9 +34,23 @@ class App extends React.Component {
     };
   }
 
+  fetchMetadata = () => {
+    if (this.state.currentUser) {
+      tooljetService.fetchMetaData().then((data) => {
+        this.setState({ onboarded: data.onboarded });
+
+        if (data.latest_version && lt(data.installed_version, data.latest_version) && data.version_ignored === false) {
+          this.setState({ updateAvailable: true });
+        }
+      });
+    }
+  };
+
   componentDidMount() {
     authenticationService.currentUser.subscribe((x) => {
       this.setState({ currentUser: x });
+      this.fetchMetadata();
+      setInterval(this.fetchMetadata, 1000 * 60 * 60 * 1);
     });
   }
 
@@ -51,7 +65,7 @@ class App extends React.Component {
   };
 
   render() {
-    const { currentUser, fetchedMetadata, updateAvailable, onboarded, darkMode } = this.state;
+    const { updateAvailable, onboarded, darkMode } = this.state;
     let toastOptions = {};
 
     if (darkMode) {
@@ -64,16 +78,6 @@ class App extends React.Component {
       };
     }
 
-    if (currentUser && fetchedMetadata === false) {
-      tooljetService.fetchMetaData().then((data) => {
-        this.setState({ fetchedMetadata: true, onboarded: data.onboarded });
-
-        if (lt(data.installed_version, data.latest_version) && data.version_ignored === false) {
-          this.setState({ updateAvailable: true });
-        }
-      });
-    }
-
     return (
       <>
         <Router history={history}>
@@ -124,7 +128,10 @@ class App extends React.Component {
                 <Redirect
                   to={{
                     pathname: '/confirm',
-                    state: { token: props.match.params.token, search: props.location.search },
+                    state: {
+                      token: props.match.params.token,
+                      search: props.location.search,
+                    },
                   }}
                 />
               )}

server/src/controllers/metadata.controller.ts

@@ -47,20 +47,13 @@ export class MetadataController {
   async getMetadata(@Request() req) {
     const metadata = await this.metadataService.getMetaData();
     const data = metadata.data;
-
     let latestVersion = data['latest_version'];
     let versionIgnored = data['version_ignored'] || false;
-    const installedVersion = globalThis.TOOLJET_VERSION;
     const onboarded = data['onboarded'];
-    const ignoredVersion = data['ignored_version'];
-    const now = new Date();
 
-    const updateLastCheckedAt = new Date(data['last_checked'] || null);
-    const diffTime = (now.getTime() - updateLastCheckedAt.getTime()) / 1000;
-
-    if (diffTime > 86400 && process.env.NODE_ENV == 'production') {
+    if (process.env.NODE_ENV == 'production') {
       if (process.env.CHECK_FOR_UPDATES) {
-        const result = await this.metadataService.checkForUpdates(installedVersion, ignoredVersion);
+        const result = await this.metadataService.checkForUpdates(metadata);
         latestVersion = result.latestVersion;
         versionIgnored = false;
       }
@@ -71,7 +64,7 @@ export class MetadataController {
     }
 
     return {
-      installed_version: installedVersion,
+      installed_version: globalThis.TOOLJET_VERSION,
       latest_version: latestVersion,
       onboarded: onboarded,
       version_ignored: versionIgnored,

server/src/services/metadata.service.ts

@@ -63,26 +63,24 @@ export class MetadataService {
     });
   }
 
-  async checkForUpdates(installedVersion: string, ignoredVersion: string) {
+  async checkForUpdates(metadata: Metadata) {
+    const installedVersion = globalThis.TOOLJET_VERSION;
     const response = await got('https://hub.tooljet.io/updates', {
       method: 'post',
-      json: { installed_version: installedVersion },
     });
-
     const data = JSON.parse(response.body);
     const latestVersion = data['latest_version'];
 
     const newOptions = {
       last_checked: new Date(),
     };
 
-    if (gt(latestVersion, installedVersion) && installedVersion !== ignoredVersion) {
+    if (gt(latestVersion, installedVersion) && installedVersion !== metadata.data['ignored_version']) {
       newOptions['latest_version'] = latestVersion;
       newOptions['version_ignored'] = false;
     }
 
     await this.updateMetaData(newOptions);
-
     return { latestVersion };
   }
 }