Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Stuk/jszip
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: Offroaders123/jszip
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 8 files changed
  • 1 contributor

Commits on Jan 20, 2024

  1. Initial TS Support

    Not sure why I try to upgrade so many big libraries to TS and ESM, it gets complicated quickly hehe.
    
    My goal is that I want to have something like JSZip, but build using only vanilla library features, and to be fully ESM compatible, as well as have first-party type definitions. Also, using a Promise-based API is key as well.
    
    https://stackoverflow.com/questions/14527820/does-html-5s-blobbuilder-still-work-in-google-chrome
    https://gist.github.com/eligrey/1079572/aeac96e31f03bb8aeecedd5e5a6a89ac92c106cc
    https://www.google.com/search?q=require%28%27setimmediate%27%29
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat
    https://stackoverflow.com/questions/29676635/convert-uint8array-to-array-in-javascript
    Offroaders123 committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9db10ae View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. TSConfig Cleanup

    Offroaders123 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5fcae51 View commit details
    Browse the repository at this point in the history
  2. Further Typings Config

    Offroaders123 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0f2c23b View commit details
    Browse the repository at this point in the history
  3. Initial Module Tree Typings Traversal

    Going to go from the bottom of the module tree to the top, to make the whole codebase type-safe! This is going to take a few different sessions.
    Offroaders123 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c6eb5ab View commit details
    Browse the repository at this point in the history
  4. More Util Typings

    I'm considering whether I should do this with a fork of the library instead, and work on modernizing that instead of the original, which seems to be a few development iteration types back (ESM, TypeScript, browser-first).
    
    https://github.com/telerik/jszip-esm
    
    It seems like a lot of work for modernizing older projects like these are that they are for Node to start with, and there are a lot of polyfills set up to make it work for modern code, rather than the other way around. To be fair, that's the same issue I'm having with my own projects from a few years ago too, so it's just going to happen, and it's still just something we have to deal with. I guess it's good that the same language has been around long enough for it to grow so much to where that is a concern. People see that as a downside to the JS ecosystem, but it also really shows how much things have grown over the years.
    
    I wish not as many new TS projects were OOP, it's still the same language under the hood, so I find it interesting how the typings for things in that manner seems to have brought non-FP concepts over to JS's fairly functional neighborhood (at least for packages, it seems like most user-facing APIs use functions where possible, and maybe the underlying implementation may use a few classes).
    Offroaders123 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    99c36b9 View commit details
    Browse the repository at this point in the history
Loading