Skip to content

Does not detect changes when making a field required in API #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mahnazEbrahimi opened this issue Mar 4, 2022 · 6 comments
Closed

Does not detect changes when making a field required in API #346

mahnazEbrahimi opened this issue Mar 4, 2022 · 6 comments
Assignees
Milestone

Comments

@mahnazEbrahimi
Copy link

If change "orientation" field to "required", no changes detected by the tool. Here is new and old api:

#Old API

"Chart": {
        "allOf": [
          {
            "$ref": "#/schemas/Visualization"
          },
          {
            "properties": {
              "orientation": {
                "enum": [
                  "VERTICAL",
                  "HORIZONTAL"
                ],
                "type": "string"
              }
            },
            "type": "object"
          }
        ],
        "type": "object"
      },

#New API

"Chart": {
        "allOf": [
          {
            "$ref": "#/schemas/Visualization"
          },
          {
            "properties": {
              "orientation": {
                "enum": [
                  "VERTICAL",
                  "HORIZONTAL"
                ],
                "type": "string"
              }
            },
            "type": "object"
          }
        ],
        "required": [
          "orientation"
        ],
        "type": "object"
      },
@joschi
Copy link
Contributor

joschi commented Mar 4, 2022

@mahnazEbrahimi Thanks for creating this issue!

Could you please share the complete or a trimmed down but working OpenAPI spec (new and old) so we can try to reproduce the issue?

@mahnazEbrahimi
Copy link
Author

Thank you for your response. Please find the working and not working OpenAPI specs in the following path:
https://github.com/mahnazEbrahimi/openapi-specs

In the not_working spec we have changed a schema called "DualAxisChart" which has a parent called "Visualization", it is referenced by our endpoint.

@mahnazEbrahimi
Copy link
Author

@joschi
Could you please give me an update on this issue? Thank you!

@Dogacel
Copy link

Dogacel commented Mar 6, 2023

We also experience the same issue 👍

@DrSatyr
Copy link
Collaborator

DrSatyr commented Jan 30, 2025

Most probably it is related to "allOf" case #571, not for required.

@DrSatyr DrSatyr added this to the 2.1.0 milestone Jan 30, 2025
@DrSatyr DrSatyr self-assigned this Jan 30, 2025
@DrSatyr
Copy link
Collaborator

DrSatyr commented Apr 17, 2025

Closed, as related to #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants