Skip to content

Commit b83a83d

Browse files
authored
Making app "create new version" dropdown into a scrollable container (ToolJet#2465)
* fixing app vrsion modal * completed fixing bottom bar * fixing typo
1 parent 4bdf39a commit b83a83d

File tree

2 files changed

+34
-20
lines changed

2 files changed

+34
-20
lines changed

frontend/src/Editor/AppVersionsManager.jsx

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -99,27 +99,31 @@ export const AppVersionsManager = function AppVersionsManager({
9999
<span className="px-1">{editingAppVersion.name}</span>
100100
</span>
101101
{showDropDown && (
102-
<div className="dropdown-menu show">
103-
{appVersions.map((version) =>
104-
releasedVersionId == version.id ? (
105-
<div className="row dropdown-item released" key={version.id} onClick={() => selectVersion(version)}>
106-
{version.name}
107-
<div className="released-subtext">
108-
<img src={'/assets/images/icons/editor/deploy-rocket.svg'} />
109-
<span className="px-1">Currently Released</span>
110-
</div>
111-
</div>
112-
) : (
113-
<div className="dropdown-item" key={version.id} onClick={() => selectVersion(version)}>
114-
{version.name}
115-
</div>
116-
)
117-
)}
118-
<div className="dropdown-divider"></div>
119-
<div className="dropdown-item" onClick={() => setShowModal(true)}>
120-
<span className="color-primary create-link">Create Version</span>
102+
<>
103+
<div className="dropdown-menu app-version-container show">
104+
<div className="app-version-content">
105+
{appVersions.map((version) =>
106+
releasedVersionId == version.id ? (
107+
<div className="row dropdown-item released" key={version.id} onClick={() => selectVersion(version)}>
108+
{version.name}
109+
<div className="released-subtext">
110+
<img src={'/assets/images/icons/editor/deploy-rocket.svg'} />
111+
<span className="px-1">Currently Released</span>
112+
</div>
113+
</div>
114+
) : (
115+
<div className="dropdown-item" key={version.id} onClick={() => selectVersion(version)}>
116+
{version.name}
117+
</div>
118+
)
119+
)}
120+
<div className="dropdown-divider"></div>
121+
</div>
122+
<div className="dropdown-item" onClick={() => setShowModal(true)}>
123+
<span className="color-primary create-link">Create Version</span>
124+
</div>
121125
</div>
122-
</div>
126+
</>
123127
)}
124128
<CreateVersionModal
125129
showModal={showModal}

frontend/src/_styles/theme.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2549,6 +2549,16 @@ hr {
25492549
}
25502550
}
25512551
}
2552+
.app-version-container {
2553+
min-height: 200px;
2554+
height: 100%;
2555+
display: flex !important;
2556+
flex-direction: column;
2557+
}
2558+
.app-version-content{
2559+
flex: 1;
2560+
overflow: auto;
2561+
}
25522562

25532563
.query-manager-header {
25542564
.nav-item {

0 commit comments

Comments
 (0)