AR-25175: Use ExpressionInfo type for RTF property in C# RtfControl

Author: maxim.vakhrushev

Advanced/PageAndRDL/RtfControl/C#/Rtf/Control/RichTextBoxFixed.cs

@@ -1,4 +1,5 @@
-using System.Text;
+using System;
+using System.Text;
 using System.Windows.Forms;
 
 using GrapeCity.ActiveReports.Samples.Rtf.Native;
@@ -52,4 +53,19 @@ private int GetTextLength(int gtl)
 			return UnsafeNativeMethods.SendMessage(Handle, NativeMethods.EM_GETTEXTLENGTHEX, ref getLength, 0);
 		}
 	}
+
+	public static class RichTextBoxExtensions
+	{
+		public static void SetRtfOrText(this RichTextBox rtb, string rtf)
+		{
+			try
+			{
+				rtb.Rtf = rtf;
+			}
+			catch (ArgumentException)
+			{
+				rtb.Text = rtf;
+			}
+		}
+	}
 }

Advanced/PageAndRDL/RtfControl/C#/Rtf/Rendering/Layout/RtfControlLayoutManager.cs

@@ -87,14 +87,13 @@ private void ResizeBoxToContent(object sender, ContentsResizedEventArgs e)
 
 		private SizeF GetNeededSize()
 		{
-			var rtf = _control.Rtf;
 			var width = TwipsToPixels(_computedSize.Width);
 
 			using (var box = new RichTextBoxFixed())
 			{
 				box.ContentsResized += ResizeBoxToContent;
 				box.Width = width;
-				box.Rtf = rtf;
+				box.SetRtfOrText(_control.Rtf);
 
 				return new SizeF(PixelsToTwips(box.Size.Width), PixelsToTwips(box.Size.Height));
 			}
@@ -132,7 +131,7 @@ private string GetNextRtf(float to)
 			{
 				rtb.ContentsResized += ResizeBoxToContent;
 				rtb.Width = TwipsToPixels(_computedSize.Width);
-				rtb.Rtf = _control.Rtf;
+				rtb.SetRtfOrText(_control.Rtf ?? string.Empty);
 
 				_lastChar = rtb.GetCharIndexFromPosition(new Point(0, bottom + rtb.PreferredHeight));
 				rtb.Select(_firstChar, _lastChar - _firstChar);

Advanced/PageAndRDL/RtfControl/C#/Rtf/Rendering/RtfRenderer.cs

@@ -4,7 +4,9 @@
 using System.Drawing.Imaging;
 using System.Windows.Forms;
 using System.Runtime.InteropServices;
+
 using GrapeCity.ActiveReports.Samples.Rtf.Native;
+using GrapeCity.ActiveReports.Samples.Rtf.Control;
 
 namespace GrapeCity.ActiveReports.Samples.Rtf.Rendering
 {
@@ -29,7 +31,7 @@ private static Image RenderImage(string rtfContent, SizeF sizeInInches, Func<Int
 		{
 			using (var richText = new RichTextBox())
 			{
-				richText.Rtf = rtfContent;
+				richText.SetRtfOrText(rtfContent);
 				richText.CreateControl();
 
 				using (var g = richText.CreateGraphics())

Advanced/PageAndRDL/RtfControl/C#/RtfDesigner/RtfDesigner.cs

@@ -12,6 +12,7 @@
 using GrapeCity.ActiveReports.PageReportModel;
 using GrapeCity.ActiveReports.Design.DdrDesigner.Behavior;
 using GrapeCity.ActiveReports.Design.DdrDesigner.Designers;
+using GrapeCity.ActiveReports.Design.DdrDesigner.Tools;
 using GrapeCity.ActiveReports.Samples.Rtf.Rendering;
 using GrapeCity.Enterprise.Data.DataEngine.Expressions;
 
@@ -39,8 +40,7 @@ public RtfDesigner()
 				CategoryAttribute.Data,
 				new DisplayNameAttribute(Properties.Resources.PropertyRtf),
 				new DescriptionAttribute(Properties.Resources.PropertyRtfDescription),
-				new EditorAttribute(typeof(MultilineStringEditor),
-				typeof(UITypeEditor))
+				new EditorAttribute(typeof(ExpressionInfoUITypeEditor), typeof(UITypeEditor))
 			);
 
 			AddProperty(this, x => x.CanGrow,
@@ -118,17 +118,14 @@ protected override void OnComponentChanged(object sender, ComponentChangedEventA
 
 		#region Public properties
 
-		public string Rtf { get; set; }
+		public ExpressionInfo Rtf { get; set; } = ExpressionInfo.EmptyString;
 
 		public string GetRtf()
 		{
 			var prop = TypeDescriptor.GetProperties(Component)[RTF_FIELD_NAME];
-			var rtf = prop.GetValue(Component);
+			var rtf = (ExpressionInfo) prop.GetValue(Component);
 
-			if (rtf != null)
-				return rtf.ToString();
-
-			return string.Empty;
+			return rtf.IsEmptyString ? string.Empty : rtf.ToString();
 		}
 
 		public void SetRtf(string rtf)
@@ -138,7 +135,7 @@ public void SetRtf(string rtf)
 			var prop = TypeDescriptor.GetProperties(Component)[RTF_FIELD_NAME];
 			var result = string.Equals(rtf, ExpressionInfo.EmptyString.ToString()) ? string.Empty : rtf;
 
-			prop.SetValue(Component, result);
+			prop.SetValue(Component, ExpressionInfo.FromString(result));
 			ReportItem.CustomProperties[RTF_FIELD_NAME].Value = result;
 		}
 
@@ -167,7 +164,7 @@ internal System.Drawing.Image RenderedRtf
 		{
 			get
 			{
-				if (string.IsNullOrWhiteSpace(Rtf))
+				if (Rtf.IsEmptyString)
 					return null;
 
 				if (_metafile != null)

Advanced/PageAndRDL/RtfControl/C#/RtfDesigner/RtfEditor.cs

@@ -2,8 +2,8 @@
 using System.Drawing;
 using System.Windows.Forms;
 
-using GrapeCity.ActiveReports.Samples.Rtf.Control;
 using GrapeCity.ActiveReports.Samples.Rtf.Native;
+using GrapeCity.ActiveReports.Samples.Rtf.Control;
 
 namespace GrapeCity.ActiveReports.Samples.Rtf
 {
@@ -42,12 +42,10 @@ public void Deactivate(bool save)
 
 			if (save)
 			{
-				_designer.SetRtf(Rtf);
+				_designer.SetRtf(Text.TrimStart().StartsWith("=") ? Text : Rtf);
 			}
 			else
 			{
-				_designer.SetRtf(_designer.GetRtf()); // force redraw without saving
-
 				while (CanUndo)
 					Undo();
 			}
@@ -119,7 +117,8 @@ private void EditorLostFocus(object sender, EventArgs e)
 
 		private void SyncWithSource()
 		{
-			Rtf = _designer.GetRtf();
+			this.SetRtfOrText(_designer.GetRtf());
+			
 			Size = _designer.Size;
 			Location = Point.Empty;
 			Margin = Padding.Empty;