Skip to content

Remove the isDistance move tag #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
AerunDev opened this issue May 1, 2025 · 0 comments · Fixed by #519
Closed
2 tasks done

Remove the isDistance move tag #501

AerunDev opened this issue May 1, 2025 · 0 comments · Fixed by #519
Assignees
Labels
Good first issue Good for newcomers User story Issues related to a new feature or request

Comments

@AerunDev
Copy link
Collaborator

AerunDev commented May 1, 2025

As a Developer
I would like to remove the isDistance move Tag
So that users won't be confused about this anymore

Context

For now, isDistance is a move tag users can configure then use on PSDK. The problem is that PSDK does not use this Tag and instead long distance moves should be set by using the move target any_other_pokemon or all_pokemon.

Acceptance criterias

  • Remove the isDistance move Tag references (moves database UI, move model, dropdown lists / selects)
  • Make sure a project that has isDistance flag in the move JSON can load or create a migration if needed
@AerunDev AerunDev added the User story Issues related to a new feature or request label May 1, 2025
@AerunDev AerunDev added the Good first issue Good for newcomers label May 13, 2025
@AerunDev AerunDev moved this from Backlog to In Progress in Pokémon Studio May 13, 2025
@AerunDev AerunDev moved this from In Progress to Backlog in Pokémon Studio May 13, 2025
@AerunDev AerunDev moved this from Backlog to Planned in Pokémon Studio May 13, 2025
@AerunDev AerunDev moved this from Planned to In Progress in Pokémon Studio Jun 4, 2025
@pw-rey pw-rey linked a pull request Jun 4, 2025 that will close this issue
7 tasks
@pw-rey pw-rey mentioned this issue Jun 4, 2025
7 tasks
@AerunDev AerunDev moved this from In Progress to In Review in Pokémon Studio Jun 4, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Pokémon Studio Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers User story Issues related to a new feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants