Skip to content

Commit edf08f6

Browse files
Fizaa Luthracommit-bot@chromium.org
authored andcommitted
[dartfuzz] Temporarily disabling Int32x4
Change-Id: I5faf799a5e3567f3f95bf65c279d0ac95363e193 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126400 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Fizaa Luthra <[email protected]>
1 parent 1a6b76a commit edf08f6

File tree

3 files changed

+11
-42
lines changed

3 files changed

+11
-42
lines changed

runtime/tools/dartfuzz/dartfuzz.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import 'dartfuzz_type_table.dart';
1414
// Version of DartFuzz. Increase this each time changes are made
1515
// to preserve the property that a given version of DartFuzz yields
1616
// the same fuzzed program for a deterministic random seed.
17-
const String version = '1.71';
17+
const String version = '1.72';
1818

1919
// Restriction on statements and expressions.
2020
const int stmtDepth = 1;

runtime/tools/dartfuzz/dartfuzz_api_table.dart

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ class DartLib {
6262
'A': DartType.INT8LIST,
6363
'C': DartType.INT16LIST,
6464
'E': DartType.INT32LIST,
65-
'F': DartType.INT32X4,
6665
'G': DartType.INT32X4LIST,
6766
'H': DartType.INT64LIST,
6867
'J': DartType.FLOAT32LIST,
@@ -89,7 +88,6 @@ class DartLib {
8988
DartType.INT8LIST: int8ListLibs,
9089
DartType.INT16LIST: int16ListLibs,
9190
DartType.INT32LIST: int32ListLibs,
92-
DartType.INT32X4: int32x4Libs,
9391
DartType.INT32X4LIST: int32x4ListLibs,
9492
DartType.INT64LIST: int64ListLibs,
9593
DartType.FLOAT32LIST: float32ListLibs,
@@ -130,10 +128,6 @@ class DartLib {
130128
DartLib('add', 'XI'),
131129
DartLib('bool.fromEnvironment', 'VS'),
132130
DartLib('endsWith', 'SS'),
133-
DartLib('flagW', 'Fv'),
134-
DartLib('flagX', 'Fv'),
135-
DartLib('flagY', 'Fv'),
136-
DartLib('flagZ', 'Fv'),
137131
DartLib('isEmpty', 'Mv'),
138132
DartLib('isEmpty', 'Sv'),
139133
DartLib('isEven', 'Iv'),
@@ -754,10 +748,10 @@ class DartLib {
754748
DartLib('ceil', 'DV'),
755749
DartLib('ceil', 'IV'),
756750
DartLib('codeUnitAt', 'SI'),
757-
DartLib('compareTo', 'SS'),
758751
DartLib('compareTo', 'DD'),
759-
DartLib('floor', 'IV'),
752+
DartLib('compareTo', 'SS'),
760753
DartLib('floor', 'DV'),
754+
DartLib('floor', 'IV'),
761755
DartLib('floor', 'DV'),
762756
DartLib('gcd', 'II'),
763757
DartLib('indexOf', 'LII'),
@@ -766,8 +760,8 @@ class DartLib {
766760
DartLib('int.tryParse', 'VS'),
767761
DartLib('lastIndexOf', 'LII'),
768762
DartLib('length', 'Mv'),
769-
DartLib('length', 'Sv'),
770763
DartLib('length', 'Lv'),
764+
DartLib('length', 'Sv'),
771765
DartLib('modInverse', 'II'),
772766
DartLib('modPow', 'III'),
773767
DartLib('removeAt', 'LI'),
@@ -778,7 +772,6 @@ class DartLib {
778772
DartLib('sign', 'Iv'),
779773
DartLib('signMask', 'Pv'),
780774
DartLib('signMask', 'Kv'),
781-
DartLib('signMask', 'Fv'),
782775
DartLib('toInt', 'DV'),
783776
DartLib('toSigned', 'II'),
784777
DartLib('toUnsigned', 'II'),
@@ -787,10 +780,6 @@ class DartLib {
787780
DartLib('truncate', 'DV'),
788781
DartLib('unicodeBomCharacterRune', 'Vv'),
789782
DartLib('unicodeReplacementCharacterRune', 'Vv'),
790-
DartLib('w', 'Fv'),
791-
DartLib('x', 'Fv'),
792-
DartLib('y', 'Fv'),
793-
DartLib('z', 'Fv'),
794783
];
795784
static const doubleLibs = [
796785
DartLib('abs', 'DV'),
@@ -911,26 +900,6 @@ class DartLib {
911900
DartLib('Int32List.fromList', 'VL'),
912901
DartLib('sublist', 'EII'),
913902
];
914-
static const int32x4Libs = [
915-
DartLib('Int32x4.bool', 'VBBBB'),
916-
DartLib('Int32x4.fromFloat32x4Bits', 'VK'),
917-
DartLib('equal', 'KK'),
918-
DartLib('greaterThan', 'KK'),
919-
DartLib('greaterThanOrEqual', 'KK'),
920-
DartLib('lessThan', 'KK'),
921-
DartLib('lessThanOrEqual', 'KK'),
922-
DartLib('notEqual', 'KK'),
923-
DartLib('shuffle', 'FI'),
924-
DartLib('shuffleMix', 'FFI'),
925-
DartLib('withFlagW', 'FB'),
926-
DartLib('withFlagX', 'FB'),
927-
DartLib('withFlagY', 'FB'),
928-
DartLib('withFlagZ', 'FB'),
929-
DartLib('withW', 'FI'),
930-
DartLib('withX', 'FI'),
931-
DartLib('withY', 'FI'),
932-
DartLib('withZ', 'FI'),
933-
];
934903
static const int32x4ListLibs = [
935904
DartLib('sublist', 'GII'),
936905
];
@@ -943,7 +912,6 @@ class DartLib {
943912
];
944913
static const float32x4Libs = [
945914
DartLib('Float32x4.fromFloat64x2', 'VP'),
946-
DartLib('Float32x4.fromInt32x4Bits', 'VF'),
947915
DartLib('Float32x4.splat', 'VD'),
948916
DartLib('Float32x4.zero', 'VV'),
949917
DartLib('abs', 'KV'),
@@ -953,7 +921,6 @@ class DartLib {
953921
DartLib('reciprocal', 'KV'),
954922
DartLib('reciprocalSqrt', 'KV'),
955923
DartLib('scale', 'KD'),
956-
DartLib('select', 'FKK'),
957924
DartLib('shuffle', 'KI'),
958925
DartLib('shuffleMix', 'KKI'),
959926
DartLib('sqrt', 'KV'),

runtime/tools/dartfuzz/gen_api_table.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ final stringToType = {
119119
int8ListEncoding: 'DartType.INT8LIST',
120120
int16ListEncoding: 'DartType.INT16LIST',
121121
int32ListEncoding: 'DartType.INT32LIST',
122-
int32x4Encoding: 'DartType.INT32X4',
122+
// int32x4Encoding: 'DartType.INT32X4',
123123
int32x4ListEncoding: 'DartType.INT32X4LIST',
124124
int64ListEncoding: 'DartType.INT64LIST',
125125
float32ListEncoding: 'DartType.FLOAT32LIST',
@@ -147,7 +147,7 @@ final typeToLibraryMethods = {
147147
'DartType.INT8LIST': int8ListLibs,
148148
'DartType.INT16LIST': int16ListLibs,
149149
'DartType.INT32LIST': int32ListLibs,
150-
'DartType.INT32X4': int32x4Libs,
150+
// 'DartType.INT32X4': int32x4Libs,
151151
'DartType.INT32X4LIST': int32x4ListLibs,
152152
'DartType.INT64LIST': int64ListLibs,
153153
'DartType.FLOAT32LIST': float32ListLibs,
@@ -202,7 +202,7 @@ main() async {
202202
dumpTable(int8ListLibs, int8ListTable);
203203
dumpTable(int16ListLibs, int16ListTable);
204204
dumpTable(int32ListLibs, int32ListTable);
205-
dumpTable(int32x4Libs, int32x4Table);
205+
// dumpTable(int32x4Libs, int32x4Table);
206206
dumpTable(int32x4ListLibs, int32x4ListTable);
207207
dumpTable(int64ListLibs, int64ListTable);
208208
dumpTable(float32ListLibs, float32ListTable);
@@ -370,8 +370,10 @@ String typeString(DartType type) {
370370
return int16ListEncoding;
371371
case 'Int32List':
372372
return int32ListEncoding;
373-
case 'Int32x4':
374-
return int32x4Encoding;
373+
// TODO(fizaaluthra): Re-enable Int32x4 after we fix
374+
// https://github.com/dart-lang/sdk/issues/39520
375+
// case 'Int32x4':
376+
// return int32x4Encoding;
375377
case 'Int32x4List':
376378
return int32x4ListEncoding;
377379
case 'Int64List':

0 commit comments

Comments
 (0)