Skip to content

Explicit for-loop optimisation or SupervisedTrainer #16

Open
@rijobro

Description

@rijobro

It seems that in the majority of tutorials, the optimisation for loop is given explicitly. In relatively few places, the SupervisedTrainer is used, despite existing for this reason.

I can see why having the explicit for loop is beneficial for tutorials - so that people are more aware of the inner workings. However, for the sake of conciseness, I would be in favour of having just one notebook (named suitably) in which the explicit for loop is given, and then from there on, using the SupervisedTrainer. Notebooks using SupervisedTrainer could then refer to the explicit notebook.

I think @ericspod is in favour of leaving the notebooks as they are, so as not to hide anything (which I understand). Anyone else have an opinion?

Activity

rijobro

rijobro commented on Sep 2, 2020

@rijobro
ContributorAuthor
wyli

wyli commented on Sep 2, 2020

@wyli
Contributor

Thanks for bringing this up! Earlier we had the feedback from the users saying that they don't want to spend time to learn yet another framework (referring to the monai.engines and monai.handlers mechanism), we therefore create those explicit forloop examples to show that many of the monai components work well in a 'vanilla' pytorch script.
Now we might have too many such examples. Perhaps we could address this after properly rearrange the examples #2 what do you think @Nic-Ma?

Nic-Ma

Nic-Ma commented on Sep 2, 2020

@Nic-Ma
Contributor

Sounds reasonable!
We should rearrange examples first then let's discuss the tutorials.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Explicit for-loop optimisation or SupervisedTrainer · Issue #16 · Project-MONAI/tutorials