Merge pull request StackStorm#617 from StackStorm/validate_example_configs

Validate example pack configs against schema during builds.

Author: Kami

Makefile

@@ -29,7 +29,7 @@ flake8: requirements .flake8
 pylint: requirements .clone_st2_repo .pylint
 
 .PHONY: configs-check
-configs-check: requirements .configs-check
+configs-check: requirements .clone_st2_repo .configs-check
 
 .PHONY: metadata-check
 metadata-check: requirements .metadata-check
@@ -64,6 +64,7 @@ packs-tests: requirements .clone_st2_repo .packs-tests
 	@echo
 	. $(VIRTUALENV_DIR)/bin/activate; if [ ! "${CHANGED_YAML}" ]; then echo No files have changed, skipping run...; fi; for file in $(CHANGED_YAML); do if [ -n "$$file" ]; then st2-check-validate-yaml-file $$file || exit 1 ; fi; done
 	. $(VIRTUALENV_DIR)/bin/activate; if [ ! "${CHANGED_JSON}" ]; then echo No files have changed, skipping run...; fi; for file in $(CHANGED_JSON); do if [ -n "$$file" ]; then st2-check-validate-json-file $$file || exit 1 ; fi; done
+	. $(VIRTUALENV_DIR)/bin/activate; if [ ! "${CHANGED_PACKS}" ]; then echo No packs have changed, skipping run...; fi; for pack in $(CHANGED_PACKS); do if [ -n "$$pack" ]; then st2-check-validate-pack-example-config $$pack || exit 1 ; fi; done
 
 .PHONY: .metadata-check
 .metadata-check:

packs/astral/astral.yaml.example

@@ -1,5 +1,5 @@
 ---
 # For North and East, use positive values
-latitude: "38.31"
-longitude: "-122.54"
+latitude: 38.31
+longitude: -122.54
 timezone: "US/Pacific"

packs/consul/config.schema.yaml

@@ -7,10 +7,10 @@
     default: "127.0.0.1"
   port:
     description: "Consul server port. Default 8500"
-    type: "string"
+    type: "integer"
     secret: false
     required: true
-    default: "8500"
+    default: 8500
   token:
     description: "Consul API token"
     type: "string"

packs/elasticsearch/config.schema.yaml

@@ -6,10 +6,10 @@
     required: true
   port:
     description: "Elasticsearch port - default 9200"
-    type: "string"
+    type: "integer"
     secret: false
     required: false
-    default: "9200"
+    default: 9200
   query_window:
     description: "Rolling window size in seconds. Default 30s"
     type: "integer"

packs/gpg/config.schema.yaml

@@ -12,7 +12,7 @@
     required: false
   debug:
     description: "Optional debug flag - set to True to enable debug mode"
-    type: "string"
+    type: "boolean"
     secret: false
     required: false
     default: false

packs/jmx/config.schema.yaml

@@ -7,10 +7,10 @@
     default: "localhost"
   port:
     description: "JMX service port. Default 7199"
-    type: "string"
+    type: "integer"
     secret: false
     required: true
-    default: "7199"
+    default: 7199
   username:
     description: "Optional JMX username"
     type: "string"
@@ -34,5 +34,7 @@
   attribute_keys:
     description: "A list of attribute keys for compound attributes"
     type: "string"
+    items:
+      type: "string"
     secret: false
     required: false

packs/nest/nest.yaml.example

@@ -1,5 +1,5 @@
 ---
 username: ""
 password: ""
-structure: 0
-device: 0
+structure: "0"
+device: "0"

packs/rackspace/config.schema.yaml

@@ -16,7 +16,7 @@
     required: true
   debug:
     description: "Optional debug flag. Set to True to enable additional logging."
-    type: "string"
+    type: "boolean"
     secret: false
     required: false
     default: false

packs/salt/config.schema.yaml

@@ -22,7 +22,7 @@
     default: pam
   verify_ssl:
     description: "Whether ST2 should verify the Salt NetAPI SSL certificate or not"
-    type: "string"
+    type: "boolean"
     secret: false
     required: false
     default: true

packs/sensu/config.schema.yaml

@@ -22,7 +22,7 @@
     required: true
   ssl:
     description: "Whether ST2 should verify the Sensu API SSL certificate or not"
-    type: "string"
+    type: "boolean"
     secret: false
     required: false
     default: false

packs/vault/config.schema.yaml

@@ -16,6 +16,6 @@
     required: false
   verify:
     description: "Whether to verify the SSL certificate or not"
-    type: "string"
+    type: "boolean"
     secret: false
     default: true

packs/victorops/config.schema.yaml

@@ -11,7 +11,7 @@
     required: true
   debug:
     description: "Debug flag used for debugging"
-    type: "string"
+    type: "boolean"
     secret: false
     required: false
     default: false