build commands are only successful if resultCode == 0 and they have no errors

This fixes facebookarchive#262.

Tested by changing a Run Script to emit strings in the form of "error:
blah" and "warning: "blah", and verified that xctool reported failure
and warnings correctly.

Author: fpotter

Common/ReporterEvents.h

@@ -95,6 +95,9 @@
 #define kReporter_EndBuildCommand_SucceededKey @"succeeded"
 #define kReporter_EndBuildCommand_EmittedOutputTextKey @"emittedOutputText"
 #define kReporter_EndBuildCommand_DurationKey @"duration"
+#define kReporter_EndBuildCommand_ResultCode @"resultCode"
+#define kReporter_EndBuildCommand_TotalNumberOfWarnings @"totalNumberOfWarnings"
+#define kReporter_EndBuildCommand_TotalNumberOfErrors @"totalNumberOfErrors"
 
 #define kReporter_BeginBuildTarget_ProjectKey @"project"
 #define kReporter_BeginBuildTarget_TargetKey @"target"

reporters/text/TextReporter.m

@@ -530,7 +530,7 @@ - (void)endBuildCommand:(NSDictionary *)event
 
   NSString *indicator = nil;
   if (succeeded) {
-    if ([outputText rangeOfString:@"warning:"].location != NSNotFound) {
+    if ([event[kReporter_EndBuildCommand_TotalNumberOfWarnings] unsignedIntegerValue] > 0) {
       indicator = [self warningIndicatorString];
     } else {
       indicator = [self passIndicatorString];

xcodebuild-shim/xcodebuild-shim/xcodebuild_shim.m

@@ -43,6 +43,7 @@ static void XTSwizzleSelectorForFunction(Class cls, SEL sel, IMP newImp)
   method_exchangeImplementations(originalMethod, newMethod);
 }
 
+// from IDEFoundation.framework
 @interface IDEActivityLogSection : NSObject
 
 // Will be 0 for success, 1 for failure.
@@ -70,6 +71,12 @@ @interface IDEActivityLogSection : NSObject
 @property(readonly) double timeStoppedRecording;
 @property(readonly) double timeStartedRecording;
 
+// The number of times "warning:" appears in the output.
+@property(readonly) NSUInteger totalNumberOfWarnings;
+
+// The number of times "error:" appears in the output.
+@property(readonly) NSUInteger totalNumberOfErrors;
+
 @end
 
 #define kDomainTypeBuildItem @"com.apple.dt.IDE.BuildLogSection"
@@ -170,12 +177,18 @@ static void AnnounceEndSection(IDEActivityLogSection *section)
     PrintJSON(EventDictionaryWithNameAndContent(
       kReporter_Events_EndBuildCommand, @{
         kReporter_EndBuildCommand_TitleKey : section.title,
-        kReporter_EndBuildCommand_SucceededKey : (section.resultCode == 0) ? @YES : @NO,
+        // Xcode will only consider something a success if resultCode == 0 AND
+        // there's no output that contains the string "error: ".
+        kReporter_EndBuildCommand_SucceededKey : ((section.resultCode == 0) &&
+                                                  (section.totalNumberOfErrors == 0)) ? @YES : @NO,
         // Sometimes things will fail and 'emittedOutputText' will be nil.  We've seen this
         // happen when Xcode's Copy command fails.  In this case, just send an empty string
         // so Reporters don't have to worry about this sometimes being [NSNull null].
         kReporter_EndBuildCommand_EmittedOutputTextKey : section.emittedOutputText ?: @"",
         kReporter_EndBuildCommand_DurationKey : @(section.timeStoppedRecording - section.timeStartedRecording),
+        kReporter_EndBuildCommand_ResultCode : @(section.resultCode),
+        kReporter_EndBuildCommand_TotalNumberOfWarnings : @(section.totalNumberOfWarnings),
+        kReporter_EndBuildCommand_TotalNumberOfErrors : @(section.totalNumberOfErrors),
       }));
   } else if ([sectionTypeString hasPrefix:kDomainTypeProductItemPrefix]) {
     NSString *project = nil;