fix get_codecs and rtp_transceive_test

Author: Rain Liu

src/rtp_transceiver/mod.rs

@@ -222,8 +222,8 @@ impl RTCRtpTransceiver {
 
     /// Codecs returns list of supported codecs
     pub(crate) async fn get_codecs(&self) -> Vec<RTCRtpCodecParameters> {
-        let codecs = self.codecs.lock().await;
-        RTPReceiverInternal::get_codecs(&*codecs, self.kind, &self.media_engine).await
+        let mut codecs = self.codecs.lock().await;
+        RTPReceiverInternal::get_codecs(&mut *codecs, self.kind, &self.media_engine).await
     }
 
     /// sender returns the RTPTransceiver's RTPSender if it has one

src/rtp_transceiver/rtp_receiver/mod.rs

@@ -175,16 +175,16 @@ impl RTPReceiverInternal {
 
         let transceiver_codecs = self.transceiver_codecs.lock().await;
         if let Some(codecs) = &*transceiver_codecs {
-            let c = codecs.lock().await;
+            let mut c = codecs.lock().await;
             parameters.codecs =
-                RTPReceiverInternal::get_codecs(&*c, self.kind, &self.media_engine).await;
+                RTPReceiverInternal::get_codecs(&mut *c, self.kind, &self.media_engine).await;
         }
 
         parameters
     }
 
     pub(crate) async fn get_codecs(
-        codecs: &[RTCRtpCodecParameters],
+        codecs: &mut [RTCRtpCodecParameters],
         kind: RTPCodecType,
         media_engine: &Arc<MediaEngine>,
     ) -> Vec<RTCRtpCodecParameters> {
@@ -193,14 +193,13 @@ impl RTPReceiverInternal {
             return media_engine_codecs;
         }
         let mut filtered_codecs = vec![];
-        for codec in &*codecs {
+        for codec in codecs {
             let (c, match_type) = codec_parameters_fuzzy_search(codec, &media_engine_codecs);
             if match_type != CodecMatch::None {
-                //TODO: Need to modify media_engine?
-                // if codec.payload_type == 0 {
-                //    codec.payload_type = c.payload_type
-                //}
-                filtered_codecs.push(c);
+                if codec.payload_type == 0 {
+                    codec.payload_type = c.payload_type;
+                }
+                filtered_codecs.push(codec.clone());
             }
         }
 

src/rtp_transceiver/rtp_transceiver_test.rs

@@ -204,7 +204,11 @@ async fn test_rtp_transceiver_set_codec_preferences_payload_type() -> Result<()>
     let answer = answer_pc.create_answer(None).await?;
 
     // VP8 with proper PayloadType
-    assert!(answer.sdp.contains("a=rtpmap:96 VP8/90000"));
+    assert!(
+        answer.sdp.contains("a=rtpmap:51 VP8/90000"),
+        "{}",
+        answer.sdp
+    );
 
     // test_codec is ignored since offerer doesn't support
     assert!(!answer.sdp.contains("test_codec"));