test: unskip tests (microsoft#644)

Author: mxschmitt

tests/async/test_dialog.py

@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import pytest
-
 from playwright.async_api import Dialog, Page
 
 
@@ -83,7 +81,6 @@ async def on_dialog(dialog: Dialog):
     assert result
 
 
-@pytest.mark.skip_browser("webkit")
 async def test_should_be_able_to_close_context_with_open_alert(browser):
     context = await browser.new_context()
     page = await context.new_page()

tests/async/test_dispatch_event.py

@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import pytest
-
 
 async def test_should_dispatch_click_event(page, server):
     await page.goto(server.PREFIX + "/input/button.html")
@@ -137,7 +135,6 @@ async def test_should_be_atomic(selectors, page, utils):
     assert await page.evaluate("() => window._clicked")
 
 
-@pytest.mark.skip_browser("webkit")
 async def test_should_dispatch_drag_drop_events(page, server):
     await page.goto(server.PREFIX + "/drag-n-drop.html")
     dataTransfer = await page.evaluate_handle("() => new DataTransfer()")
@@ -150,7 +147,6 @@ async def test_should_dispatch_drag_drop_events(page, server):
     )
 
 
-@pytest.mark.skip_browser("webkit")
 async def test_should_dispatch_drag_and_drop_events_element_handle(page, server):
     await page.goto(server.PREFIX + "/drag-n-drop.html")
     dataTransfer = await page.evaluate_handle("() => new DataTransfer()")

tests/async/test_navigation.py

@@ -536,7 +536,6 @@ async def test_wait_for_nav_should_work_with_dom_history_back_forward(page, serv
     assert page.url == server.PREFIX + "/second.html"
 
 
-@pytest.mark.skip_browser("firefox")
 async def test_wait_for_nav_should_work_when_subframe_issues_window_stop(page, server):
     server.set_route("/frames/style.css", lambda _: None)
     navigation_promise = asyncio.create_task(

tests/async/test_page.py

@@ -417,9 +417,7 @@ async def test_page_error_should_handle_odd_values(page, is_firefox):
         )
 
 
-@pytest.mark.skip_browser("firefox")
 async def test_page_error_should_handle_object(page, is_chromium):
-    # Firefox just does not report this error.
     async with page.expect_event("pageerror") as error_info:
         await page.evaluate("() => setTimeout(() => { throw {}; }, 0)")
     error = await error_info.value
@@ -903,9 +901,7 @@ async def test_fill_should_fill_textarea(page, server):
     assert await page.evaluate("result") == "some value"
 
 
-@pytest.mark.skip_browser("webkit")
 async def test_fill_should_fill_input(page, server):
-    # Disabled as in upstream, we should validate time in the Playwright lib
     await page.goto(server.PREFIX + "/input/textarea.html")
     await page.fill("input", "some value")
     assert await page.evaluate("result") == "some value"

tests/async/test_websocket.py

@@ -109,7 +109,6 @@ def on_web_socket(ws):
     assert received == ["incoming", b"\x04\x02"]
 
 
-@pytest.mark.skip_browser("webkit")  # Flakes on bots
 async def test_should_reject_wait_for_event_on_close_and_error(page, ws_server):
     async with page.expect_event("websocket") as ws_info:
         await page.evaluate(

tests/async/test_worker.py

@@ -62,7 +62,6 @@ async def test_workers_should_report_console_logs(page):
     assert message.text == "1"
 
 
-@pytest.mark.skip_browser("firefox")  # TODO: investigate further @pavelfeldman
 async def test_workers_should_have_JSHandles_for_console_logs(page):
     log_promise = asyncio.Future()
     page.on("console", lambda m: log_promise.set_result(m))
@@ -100,7 +99,6 @@ async def test_workers_should_report_errors(page):
     assert "this is my error" in error_log.message
 
 
-@pytest.mark.skip_browser("firefox")  # TODO: fails upstream
 async def test_workers_should_clear_upon_navigation(server, page):
     await page.goto(server.EMPTY_PAGE)
     async with page.expect_event("worker") as event_info:
@@ -116,7 +114,6 @@ async def test_workers_should_clear_upon_navigation(server, page):
     assert len(page.workers) == 0
 
 
-@pytest.mark.skip_browser("firefox")  # TODO: fails upstream
 async def test_workers_should_clear_upon_cross_process_navigation(server, page):
     await page.goto(server.EMPTY_PAGE)
     async with page.expect_event("worker") as event_info: