SDWebImage#406 - Fixed a problem where hitting a failed URL more than once wouldn't call the completion block

Dale Buckley · Dale Buckley · commit 7d9c93fb515b · 2013-06-04T12:04:36.000+01:00
diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m
@@ -91,7 +91,11 @@ - (NSString *)cacheKeyForURL:(NSURL *)url
 
     if (!url || !completedBlock || (!(options & SDWebImageRetryFailed) && isFailedUrl))
     {
-        if (completedBlock) completedBlock(nil, nil, SDImageCacheTypeNone, NO);
+        if (completedBlock)
+        {
+            NSError *error = [NSError errorWithDomain:NSURLErrorDomain code:NSURLErrorFileDoesNotExist userInfo:nil];
+            completedBlock(nil, error, SDImageCacheTypeNone, YES);
+        }
         return operation;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,11 @@ - (NSString )cacheKeyForURL:(NSURL )url`
`91`	`91`
`92`	`92`	`if (!url \|\| !completedBlock \|\| (!(options & SDWebImageRetryFailed) && isFailedUrl))`
`93`	`93`	`{`
`94`		`- if (completedBlock) completedBlock(nil, nil, SDImageCacheTypeNone, NO);`
	`94`	`+ if (completedBlock)`
	`95`	`+ {`
	`96`	`+ NSError *error = [NSError errorWithDomain:NSURLErrorDomain code:NSURLErrorFileDoesNotExist userInfo:nil];`
	`97`	`+ completedBlock(nil, error, SDImageCacheTypeNone, YES);`
	`98`	`+ }`
`95`	`99`	`return operation;`
`96`	`100`	`}`
`97`	`101`