Skip to content

Implement DeviceCopy for feature gated vek types #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beepster4096 opened this issue Dec 19, 2021 · 2 comments
Open

Implement DeviceCopy for feature gated vek types #24

beepster4096 opened this issue Dec 19, 2021 · 2 comments

Comments

@beepster4096
Copy link
Contributor

Currently, DeviceCopy is only implemented for the vek types not under any features. This is a problem if you need to use any of the feature gated types. For example, I am writing image data from a GPU kernel, so I need to have a DeviceBuffer<vek::Rgb<u8>> to write to and copy from.

@beepster4096
Copy link
Contributor Author

Since it was an intentional choice to disable default features on vek, this should be put under its own feature flag in cust.

@RDambrosio016
Copy link
Member

I need to investigate this a bit, vek was causing some issues because cargo's feature selection weirdness was causing weirdness when using it from cpu and gpu, causing it to try and pull in serde on the gpu with catastrophic results. So i had to use vek with no features in cust. This feature selection bug is a nightmare because it sometimes works based on what you build first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants