PDF Viewer on mozilla

[costinarsene]

What is the issue and how can we reproduce it?

Inside PDFViewer.prototype._onLoadListener

on .then((sCurrentContentType) => {..}

missing .bind(this) . The same apllies for the next catch in current promise

It is replicated for 1.96 -1.108

Which OpenUI5 version is your project targeting?

1.96 -1.108

Is the issue device- or browser-specific?

Replicated on Firefox latest version

Confirmation

• I have searched the existing issues and reviewed the relevant documentation as well as the API reference.
• I am not disclosing any internal or sensitive information.

[codeworrior]

I don't get your point yet, @costinarsene. The code that you linked, uses arrow functions. Arrow functions use the same this as the code in which they are located. Or are you suggesting, that arrow functions don't work in Firefox when used for an event originating from an iframe (as @nyckysoft's PR suggests)?

Maybe you can share the actual error that you encounter. That might help us in understanding what's going wrong.

P.S.: I hope that the code in question wasn't downported to 1.96 as we don't support arrow functions in that code line

[nyckysoft]

I don't get your point yet, @costinarsene. The code that you linked, uses arrow functions. Arrow functions use the same this as the code in which they are located. Or are you suggesting, that arrow functions don't work in Firefox when used for an event originating from an iframe (as @nyckysoft's PR suggests)?

Maybe you can share the actual error that you encounter. That might help us in understanding what's going wrong.

P.S.: I hope that the code in question wasn't downported to 1.96 as we don't support arrow functions in that code line

The matter is about the precise version 1.96.38 in which there are clasic functions but that specific one is missing the .bind(this). This cause the script to run in an exception which is caught but the function (clasical function) in catch is also missing the .bind(this)

[costinarsene]

@codeworrior I made a mistake. The issue is replicated on 1.96 until 1.108. Over there you did not use arrow function. I modified the initial issue.

[MapTo0]

Hello @costinarsene ,

Thank you for sharing this finding. I've created an internal incident DINC0500021. The status of the issue will be updated here in GitHub.

Regards,
Martin

[AshwinKumarBolar]

Hello @costinarsene

Thank you for pointing to the issue present here. However this has already been integrated within the long term branches between 1.96 -1.108
For branches apart from 1.96 the changes has are already available.

For version 1.96 you would need to wait for the next patch to be produced for the issue to be resolved.
Change is already available here: c453d89

Thanks,
Ashwin