Fix quality flaws (#268)

Author: dorian-burihabwa-sonarsource

sonar-xml-plugin/src/main/java/org/sonar/plugins/xml/checks/XPathCheck.java

@@ -189,7 +189,7 @@ public String getNamespaceForPrefix(String prefix) {
 
     @CheckForNull
     public String getNamespaceForPrefix(String prefix, Node namespaceContext) {
-      if (prefix.equals("xml")) {
+      if ("xml".equals(prefix)) {
         return "http://www.w3.org/XML/1998/namespace";
       }
 

sonar-xml-plugin/src/main/java/org/sonar/plugins/xml/checks/security/HardcodedCredentialsCheck.java

@@ -122,7 +122,7 @@ private static boolean isCredentialNode(Node node, Set<String> credentialWords)
       return false;
     }
     return credentialWords.contains(localName.toLowerCase(Locale.ROOT)) &&
-      !node.getNodeName().equalsIgnoreCase("android:password");
+      !"android:password".equalsIgnoreCase(node.getNodeName());
   }
 
   private void checkCredential(Node node, String candidate) {

sonar-xml-plugin/src/test/java/org/sonar/plugins/xml/XmlSensorTest.java

@@ -112,7 +112,7 @@ void testPerformance() throws Exception {
     fs.add(createInputFile(Paths.get(bigXmlFile.getParent()), bigXmlFile.getName(), StandardCharsets.UTF_8));
     long timeBigFile = measureTimeToAnalyzeFile();
 
-    assertThat(timeBigFile < (2.5 * timeSmallFile)).isTrue();
+    assertThat(timeBigFile).isLessThan((long) Math.floor(2.5 * timeSmallFile));
   }
 
   @Test