Skip to content

Commit 303958b

Browse files
Merge pull request #28 from tplaner/master
Ensures `evt.from` contains cloned element before trying to remove it
2 parents 56e97c3 + a0e731f commit 303958b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

angular-legacy-sortable.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,10 @@
115115
if (evt.clone) {
116116
removed = angular.copy(removed);
117117
prevItems.splice(Sortable.utils.index(evt.clone, sortable.options.draggable), 0, prevItems.splice(oldIndex, 1)[0]);
118-
evt.from.removeChild(evt.clone);
118+
119+
if (evt.from.contains(evt.clone)) {
120+
evt.from.removeChild(evt.clone);
121+
}
119122
}
120123
else {
121124
prevItems.splice(oldIndex, 1);

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@
2121
},
2222
"homepage": "https://github.com/SortableJS/angular-legacy-sortablejs#readme",
2323
"peerDependencies": {
24-
"sortablejs": "~1.4.0"
24+
"sortablejs": "~1.5.x"
2525
}
2626
}

0 commit comments

Comments
 (0)