Refine some bincode type stuff and style things

Author: InKryption

scripts/style.py

@@ -131,10 +131,6 @@ def unused_imports(args, files_to_check):
 
 
 files_excluded_from_line_length_check = [
-    "src/bincode/arraylist.zig",
-    "src/bincode/bincode.zig",
-    "src/bincode/int.zig",
-    "src/bincode/shortvec.zig",
     "src/bloom/bit_set.zig",
     "src/bloom/bit_vec.zig",
     "src/bloom/bitvec.zig",

src/accountsdb/buffer_pool.zig

@@ -1112,7 +1112,7 @@ pub const AccountDataHandle = union(enum) {
         writer: anytype,
         read_handle: anytype,
         params: bincode.Params,
-    ) anyerror!void {
+    ) !void {
         // we want to serialise it as if it's a slice
         try bincode.write(writer, @as(u64, read_handle.len()), params);
 
@@ -1126,12 +1126,12 @@ pub const AccountDataHandle = union(enum) {
         alloc: std.mem.Allocator,
         reader: anytype,
         params: bincode.Params,
-    ) anyerror!AccountDataHandle {
+    ) !AccountDataHandle {
         const data = try bincode.read(alloc, []u8, reader, params);
         return AccountDataHandle.initAllocatedOwned(data);
     }
 
-    fn bincodeFree(allocator: std.mem.Allocator, read_handle: anytype) void {
+    fn bincodeFree(allocator: std.mem.Allocator, read_handle: AccountDataHandle) void {
         read_handle.deinit(allocator);
     }
 };

src/accountsdb/snapshots.zig

@@ -263,8 +263,7 @@ pub const ExtraFields = struct {
         return extra_fields;
     }
 
-    fn bincodeFree(allocator: std.mem.Allocator, data: anytype) void {
-        comptime if (@TypeOf(data) == ExtraFields) unreachable;
+    fn bincodeFree(allocator: std.mem.Allocator, data: ExtraFields) void {
         data.deinit(allocator);
     }
 };
@@ -488,7 +487,7 @@ pub const AccountsDbFields = struct {
         };
     }
 
-    fn bincodeWrite(writer: anytype, data: anytype, params: bincode.Params) !void {
+    fn bincodeWrite(writer: anytype, data: AccountsDbFields, params: bincode.Params) !void {
         comptime if (@TypeOf(data) != AccountsDbFields) unreachable;
 
         {
@@ -510,7 +509,7 @@ pub const AccountsDbFields = struct {
         try bincode.write(writer, data.rooted_slot_hashes, params);
     }
 
-    fn bincodeFree(allocator: std.mem.Allocator, data: anytype) void {
+    fn bincodeFree(allocator: std.mem.Allocator, data: AccountsDbFields) void {
         data.deinit(allocator);
     }
 };

src/bincode/arraylist.zig

@@ -13,7 +13,7 @@ pub fn standardConfig(comptime List: type) bincode.FieldConfig(List) {
     const list_info = arrayListInfo(List).?;
 
     const S = struct {
-        fn serialize(writer: anytype, data: anytype, params: bincode.Params) anyerror!void {
+        fn serialize(writer: anytype, data: List, params: bincode.Params) !void {
             try bincode.write(writer, data.items.len, params);
             for (data.items) |item| try bincode.write(writer, item, params);
         }
@@ -22,17 +22,21 @@ pub fn standardConfig(comptime List: type) bincode.FieldConfig(List) {
             allocator: std.mem.Allocator,
             reader: anytype,
             params: Params,
-        ) anyerror!List {
-            const len = (try readIntAsLength(usize, reader, params)) orelse return error.ArrayListTooBig;
+        ) !List {
+            const maybe_len = try readIntAsLength(usize, reader, params);
+            const len = maybe_len orelse return error.ArrayListTooBig;
 
             var data: List = try List.initCapacity(allocator, len);
             errdefer free(allocator, data);
 
-            for (0..len) |_| data.appendAssumeCapacity(try bincode.read(allocator, list_info.Elem, reader, params));
+            for (0..len) |_| {
+                const elem = try bincode.read(allocator, list_info.Elem, reader, params);
+                data.appendAssumeCapacity(elem);
+            }
             return data;
         }
 
-        fn free(allocator: std.mem.Allocator, data: anytype) void {
+        fn free(allocator: std.mem.Allocator, data: List) void {
             var copy = data;
             for (copy.items) |value| bincode.free(allocator, value);
             switch (list_info.management) {
@@ -51,9 +55,15 @@ pub fn standardConfig(comptime List: type) bincode.FieldConfig(List) {
 
 /// Defaults the field of type `List` to an empty state on EOF.
 pub fn defaultOnEofConfig(comptime List: type) bincode.FieldConfig(List) {
-    const al_info = arrayListInfo(List) orelse @compileError("Expected std.ArrayList[Unmanaged]Aligned(T), got " ++ @typeName(List));
+    const al_info = arrayListInfo(List) orelse @compileError(
+        "Expected std.ArrayList[Unmanaged]Aligned(T), got " ++ @typeName(List),
+    );
     const S = struct {
-        fn deserialize(allocator: std.mem.Allocator, reader: anytype, params: bincode.Params) anyerror!List {
+        fn deserialize(
+            allocator: std.mem.Allocator,
+            reader: anytype,
+            params: bincode.Params,
+        ) !List {
             const len = if (bincode.readIntAsLength(usize, reader, params)) |maybe_len|
                 (maybe_len orelse return error.ArrayListTooBig)
             else |err| switch (err) {
@@ -74,7 +84,7 @@ pub fn defaultOnEofConfig(comptime List: type) bincode.FieldConfig(List) {
             };
         }
 
-        fn free(allocator: std.mem.Allocator, data: anytype) void {
+        fn free(allocator: std.mem.Allocator, data: List) void {
             var copy = data;
             for (copy.items) |value| bincode.free(allocator, value);
             switch (al_info.management) {