Merge pull request rmosolgo#2450 from chrisbutcher/add-extras-setter-to-graphql-schema-field

Add `extras` setter to GraphQL::Schema::Field

Author: rmosolgo

lib/graphql/schema/field.rb

@@ -46,9 +46,6 @@ def resolver
 
       alias :mutation :resolver
 
-      # @return [Array<Symbol>]
-      attr_reader :extras
-
       # @return [Boolean] Apply tracing to this field? (Default: skip scalars, this is the override value)
       attr_reader :trace
 
@@ -318,6 +315,21 @@ def extension(extension, options = nil)
         extensions([{extension => options}])
       end
 
+      # Read extras (as symbols) from this field,
+      # or add new extras to be opted into by this field's resolver.
+      #
+      # @param new_extras [Array<Symbol>] Add extras to this field
+      # @return [Array<Symbol>]
+      def extras(new_extras = nil)
+        if new_extras.nil?
+          # Read the value
+          @extras
+        else
+          # Append to the set of extras on this field
+          @extras.concat(new_extras)
+        end
+      end
+
       def complexity(new_complexity)
         case new_complexity
         when Proc

spec/graphql/schema/field_spec.rb

@@ -129,6 +129,24 @@
         assert_equal "TRUE", res["data"]["upcaseCheck3"]
         assert_equal "\"WHY NOT?\"", res["data"]["upcaseCheck4"]
       end
+
+      it "can be read via #extras" do
+        field = Jazz::Musician.fields["addError"]
+        assert_equal [:execution_errors], field.extras
+      end
+
+      it "can be added by passing an array of symbols to #extras" do
+        object = Class.new(Jazz::BaseObject) do
+          graphql_name "JustAName"
+
+          field :test, String, null: true, extras: [:lookahead]
+        end
+
+        field = object.fields['test']
+
+        field.extras([:ast_node])
+        assert_equal [:lookahead, :ast_node], field.extras
+      end
     end
 
     it "is the #owner of its arguments" do