introduce support for SQL_TYPE_TIME type

Fixes alexbrainman#92

Author: alexbrainman

api/api.go

@@ -19,6 +19,12 @@ type (
 		Day   SQLUSMALLINT
 	}
 
+	SQL_TIME_STRUCT struct {
+		Hour   SQLUSMALLINT
+		Minute SQLUSMALLINT
+		Second SQLUSMALLINT
+	}
+
 	SQL_TIMESTAMP_STRUCT struct {
 		Year     SQLSMALLINT
 		Month    SQLUSMALLINT

column.go

@@ -83,6 +83,9 @@ func NewColumn(h api.SQLHSTMT, idx int) (Column, error) {
 	case api.SQL_TYPE_DATE:
 		var v api.SQL_DATE_STRUCT
 		return NewBindableColumn(b, api.SQL_C_DATE, int(unsafe.Sizeof(v))), nil
+	case api.SQL_TYPE_TIME:
+		var v api.SQL_TIME_STRUCT
+		return NewBindableColumn(b, api.SQL_C_TIME, int(unsafe.Sizeof(v))), nil
 	case api.SQL_GUID:
 		var v api.SQLGUID
 		return NewBindableColumn(b, api.SQL_C_GUID, int(unsafe.Sizeof(v))), nil
@@ -158,6 +161,11 @@ func (c *BaseColumn) Value(buf []byte) (driver.Value, error) {
 		r := time.Date(int(t.Year), time.Month(t.Month), int(t.Day),
 			0, 0, 0, 0, time.Local)
 		return r, nil
+	case api.SQL_C_TIME:
+		t := (*api.SQL_TIME_STRUCT)(p)
+		r := time.Date(1, time.January, 1,
+			int(t.Hour), int(t.Minute), int(t.Second), 0, time.Local)
+		return r, nil
 	case api.SQL_C_BINARY:
 		return buf, nil
 	}

mysql_test.go

@@ -0,0 +1,60 @@
+// Copyright 2017 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package odbc
+
+import (
+	"database/sql"
+	"flag"
+	"fmt"
+	"testing"
+	"time"
+)
+
+var (
+	mysrv  = flag.String("mysrv", "server", "mysql server name")
+	mydb   = flag.String("mydb", "dbname", "mysql database name")
+	myuser = flag.String("myuser", "", "mysql user name")
+	mypass = flag.String("mypass", "", "mysql password")
+)
+
+func mysqlConnect() (db *sql.DB, stmtCount int, err error) {
+	// from https://dev.mysql.com/doc/connector-odbc/en/connector-odbc-configuration-connection-parameters.html
+	conn := fmt.Sprintf("driver=mysql;server=%s;database=%s;user=%s;password=%s;",
+		*mysrv, *mydb, *myuser, *mypass)
+	db, err = sql.Open("odbc", conn)
+	if err != nil {
+		return nil, 0, err
+	}
+	stats := db.Driver().(*Driver).Stats
+	return db, stats.StmtCount, nil
+}
+
+func TestMYSQLTime(t *testing.T) {
+	db, sc, err := mysqlConnect()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer closeDB(t, db, sc, sc)
+
+	db.Exec("drop table temp")
+	exec(t, db, "create table temp(id int not null auto_increment primary key, time time)")
+	now := time.Now()
+	// SQL_TIME_STRUCT only supports hours, minutes and seconds
+	now = time.Date(1, time.January, 1, now.Hour(), now.Minute(), now.Second(), 0, time.Local)
+	_, err = db.Exec("insert into temp (time) values(?)", now)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	var ret time.Time
+	if err := db.QueryRow("select time from temp where id = ?", 1).Scan(&ret); err != nil {
+		t.Fatal(err)
+	}
+	if ret != now {
+		t.Fatalf("unexpected return value: want=%v, is=%v", now, ret)
+	}
+
+	exec(t, db, "drop table temp")
+}