Skip to content

Commit f0492df

Browse files
committed
make sure current code is not crashing even when compiled with
-gcflags=all=-d=checkptr flag (see https://golang.org/issues/34964 for details). Verified with go test ... --race on both Windows and Linux. Fixes alexbrainman#144
1 parent fd264d0 commit f0492df

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ start-mssql:
1919
test-mssql:
2020
go test -v -mssrv=localhost -msdb=$(DB_NAME) -msuser=sa -mspass=$(MSSQL_SA_PASSWORD) -run=TestMSSQL
2121

22+
test-mssql-race:
23+
go test -v -mssrv=localhost -msdb=$(DB_NAME) -msuser=sa -mspass=$(MSSQL_SA_PASSWORD) -run=TestMSSQL --race
24+
2225
stop-mssql:
2326
docker stop $(MSSQL_CONTAINER_NAME)
2427
docker rm $(MSSQL_CONTAINER_NAME)

column.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func (c *BaseColumn) Value(buf []byte) (driver.Value, error) {
141141
if p == nil {
142142
return buf, nil
143143
}
144-
s := (*[1 << 28]uint16)(p)[:len(buf)/2]
144+
s := (*[1 << 28]uint16)(p)[: len(buf)/2 : len(buf)/2]
145145
return utf16toutf8(s), nil
146146
case api.SQL_C_TYPE_TIMESTAMP:
147147
t := (*api.SQL_TIMESTAMP_STRUCT)(p)

0 commit comments

Comments
 (0)