Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: VariantSync/DiffDetective
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: VariantSync/DiffDetective
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: thesis_bm
Choose a head ref
  • 3 commits
  • 33 files changed
  • 1 contributor

Commits on Jul 23, 2023

  1. Do not remove BOMs from diffs 

    This is a discrepancy between the `GitDiffer` and my the variation tree
parsing in `ConstructionValidation` causing assertion failures.
    @ibbem
    ibbem committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3e83d84 View commit details
    Browse the repository at this point in the history

  2. Record the runtime of the original diffing algorithm

    @ibbem
    ibbem committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    dabab13 View commit details
    Browse the repository at this point in the history

  3. Patch Gumtree to add MappingStore.assertConsistency 

    The CompositeMatchers.XyMatcher algorithm adds incompatible matchings
for nodes which already have a matching. As this is the fastest matcher,
it's useful to test it further. Thus, incompatible matchings are ignored
and a debug message is printed.

For example, given a matching between A and B
| src -> dst | dst -> src |
|------------|------------|
| A -> B     | B -> A     |

When the incompatible matching between B and C is added, the result is:
| src -> dst | dst -> src |
|------------|------------|
| A -> B     |            |
| C -> B     | B -> C     |

Thus the matching between B and C is ignored if XyMatcher tries to add
it.
    @ibbem
    ibbem committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    7e37149 View commit details
    Browse the repository at this point in the history
Loading