fix(QueryParserSpecification) update to match ligraphqlparser

Author: rmosolgo

lib/graphql/compatibility/query_parser_specification.rb

@@ -37,19 +37,6 @@ def test_it_parses_queries
             assert_valid_typeless_inline_fragment(query.selections[3])
           end
 
-          def test_it_parses_empty_arguments
-            strings = [
-              "{ field { } }",
-              "{ field() }",
-            ]
-            strings.each do |query_str|
-              doc = parse(query_str)
-              field = doc.definitions.first.selections.first
-              assert_equal 0, field.arguments.length
-              assert_equal 0, field.selections.length
-            end
-          end
-
           def test_it_parses_unnamed_queries
             document = parse("{ name, age, height }")
             operation =  document.definitions.first
@@ -59,14 +46,18 @@ def test_it_parses_unnamed_queries
             assert_equal 3, operation.selections.length
           end
 
+          def test_it_parses_the_introspection_query
+            parse(GraphQL::Introspection::INTROSPECTION_QUERY)
+          end
+
           def test_it_parses_inputs
             query_string = %|
               {
                 field(
                   int: 3,
                   float: 4.7e-24,
                   bool: false,
-                  string: "☀︎🏆\\n escaped \\" unicode \\u00b6 /",
+                  string: "☀︎🏆\\n escaped \\" unicode \u00b6 /",
                   enum: ENUM_NAME,
                   array: [7, 8, 9]
                   object: {a: [1,2,3], b: {c: "4"}}

lib/graphql/compatibility/query_parser_specification/parse_error_specification.rb

@@ -15,7 +15,7 @@ def test_it_includes_line_and_column
             }
           ")
 
-          assert_includes(err.message, '"{"')
+          assert_includes(err.message, '{')
           assert_equal(3, err.line)
           assert_equal(27, err.col)
         end
@@ -31,7 +31,10 @@ def test_it_rejects_unexpected_ends
 
         def assert_rejects_character(char)
           err = assert_raises_parse_error("{ field#{char} }")
-          assert_includes(err.message, char.inspect, "The message includes the invalid character")
+          expected_char = char.inspect.gsub('"', '').downcase
+          msg_downcase = err.message.downcase
+          # Case-insensitive for UTF-8 printing
+          assert_includes(msg_downcase, expected_char, "The message includes the invalid character")
         end
 
         def test_it_rejects_invalid_characters

spec/graphql/language/parser_spec.rb

@@ -11,32 +11,35 @@
       }
     |}
 
-    describe ".parse" do
-      it "parses queries" do
-        assert document
-      end
-
-      describe "visited nodes" do
-        let(:fragment) { document.definitions.first }
-
-        it "creates an anonymous fragment definition" do
-          assert fragment.is_a?(GraphQL::Language::Nodes::FragmentDefinition)
-          assert_equal nil, fragment.name
-          assert_equal 1, fragment.selections.length
-          assert_equal "NestedType", fragment.type.name
-          assert_equal 1, fragment.directives.length
-          assert_equal [2, 7], fragment.position
-        end
-      end
-
-      it "parses the test schema" do
-        schema = DummySchema
-        schema_string = GraphQL::Schema::Printer.print_schema(schema)
-
-        document = subject.parse(schema_string)
+    let(:fragment) { document.definitions.first }
+
+    it "creates an anonymous fragment definition" do
+      assert fragment.is_a?(GraphQL::Language::Nodes::FragmentDefinition)
+      assert_equal nil, fragment.name
+      assert_equal 1, fragment.selections.length
+      assert_equal "NestedType", fragment.type.name
+      assert_equal 1, fragment.directives.length
+      assert_equal [2, 7], fragment.position
+    end
+  end
 
-        assert_equal schema_string, document.to_query_string
-      end
+  it "parses empty arguments" do
+    strings = [
+      "{ field { inner } }",
+      "{ field() { inner }}",
+    ]
+    strings.each do |query_str|
+      doc = subject.parse(query_str)
+      field = doc.definitions.first.selections.first
+      assert_equal 0, field.arguments.length
+      assert_equal 1, field.selections.length
     end
   end
+
+  it "parses the test schema" do
+    schema = DummySchema
+    schema_string = GraphQL::Schema::Printer.print_schema(schema)
+    document = subject.parse(schema_string)
+    assert_equal schema_string, document.to_query_string
+  end
 end