bug fix:LibAddressSet remove: error index

irvinli · irvinli · commit a7e55498f449 · 2021-04-15T21:08:26.000+08:00
diff --git a/contracts/data_structure/LibAddressSet.sol b/contracts/data_structure/LibAddressSet.sol
@@ -41,7 +41,7 @@ library LibAddressSet {
         uint256 lastindexMapping = self.values.length - 1;
         address lastValue = self.values[lastindexMapping];
         self.values[toDeleteindexMapping] = lastValue;
-        self.indexMapping[lastValue] = toDeleteindexMapping; 
+        self.indexMapping[lastValue] = toDeleteindexMapping + 1; 
         self.values.pop();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ library LibAddressSet {`
`41`	`41`	`uint256 lastindexMapping = self.values.length - 1;`
`42`	`42`	`address lastValue = self.values[lastindexMapping];`
`43`	`43`	`self.values[toDeleteindexMapping] = lastValue;`
`44`		`- self.indexMapping[lastValue] = toDeleteindexMapping;`
	`44`	`+ self.indexMapping[lastValue] = toDeleteindexMapping + 1;`
`45`	`45`	`self.values.pop();`
`46`	`46`	`}`
`47`	`47`