Upgrade slf4j, jaskcon and netty and update the module path tests

Author: zoewangg

.changes/next-release/feature-AWSSDKforJavav2-959855c.json

@@ -0,0 +1,5 @@
+{
+    "category": "AWS SDK for Java v2", 
+    "type": "feature", 
+    "description": "Update jackson, slf4j, netty versions."
+}

pom.xml

@@ -84,19 +84,19 @@
     </scm>
     <properties>
         <awsjavasdk.version>${project.version}</awsjavasdk.version>
-        <jackson.version>2.9.8</jackson.version>
+        <jackson.version>2.9.9</jackson.version>
         <jackson.annotations.version>2.9.0</jackson.annotations.version>
         <eventstream.version>1.0.1</eventstream.version>
         <ion.java.version>1.2.0</ion.java.version>
         <commons.lang.version>3.4</commons.lang.version>
         <wiremock.version>2.18.0</wiremock.version>
-        <slf4j.version>1.7.25</slf4j.version>
+        <slf4j.version>1.7.28</slf4j.version>
         <log4j.version>1.2.17</log4j.version>
         <commons.io.version>2.5</commons.io.version>
         <equalsverifier.version>2.3.3</equalsverifier.version>
         <!-- Update netty-open-ssl-version accordingly whenever we update netty version-->
         <!-- https://github.com/netty/netty/blob/4.1/pom.xml#L286 -->
-        <netty.version>4.1.39.Final</netty.version>
+        <netty.version>4.1.41.Final</netty.version>
         <unitils.version>3.3</unitils.version>
         <xmlunit.version>1.3</xmlunit.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

test/module-path-tests/pom.xml

@@ -48,31 +48,22 @@
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>s3</artifactId>
             <version>${awsjavasdk.version}</version>
-            <exclusions>
-                <exclusion>
-                     <!-- TODO remove exclusions after we fix netty module -->
-                    <artifactId>netty-nio-client</artifactId>
-                    <groupId>software.amazon.awssdk</groupId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>protocol-tests</artifactId>
             <version>${awsjavasdk.version}</version>
-            <exclusions>
-                <exclusion>
-                     <!-- TODO remove exclusions after we fix netty module -->
-                    <artifactId>netty-nio-client</artifactId>
-                    <groupId>software.amazon.awssdk</groupId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>apache-client</artifactId>
             <version>${awsjavasdk.version}</version>
         </dependency>
+        <dependency>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>netty-nio-client</artifactId>
+            <version>${awsjavasdk.version}</version>
+        </dependency>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>url-connection-client</artifactId>

test/module-path-tests/src/main/java/module-info.java

@@ -17,6 +17,7 @@
     requires software.amazon.awssdk.regions;
     requires software.amazon.awssdk.http.urlconnection;
     requires software.amazon.awssdk.http.apache;
+    requires software.amazon.awssdk.http.nio.netty;
     requires software.amazon.awssdk.http;
     requires software.amazon.awssdk.core;
     requires software.amazon.awssdk.awscore;
@@ -27,9 +28,6 @@
     requires software.amazon.awssdk.utils;
     requires software.amazon.awssdk.testutils.service;
 
-    // This is fine because those are just used in unit test.
-    // https://jira.qos.ch/browse/SLF4J-420
-    requires slf4j.api;
+    requires org.slf4j;
     requires slf4j.simple;
-
 }

test/module-path-tests/src/main/java/software/amazon/awssdk/modulepath/tests/integtests/S3ApiCall.java

@@ -15,15 +15,14 @@
 
 package software.amazon.awssdk.modulepath.tests.integtests;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import software.amazon.awssdk.http.apache.ApacheHttpClient;
+import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
 import software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient;
 import software.amazon.awssdk.regions.Region;
+import software.amazon.awssdk.services.s3.S3AsyncClient;
 import software.amazon.awssdk.services.s3.S3Client;
 
 public class S3ApiCall extends BaseApiCall {
-    private static final Logger logger = LoggerFactory.getLogger(S3ApiCall.class);
 
     private S3Client s3Client = S3Client.builder()
                                         .region(Region.US_WEST_2)
@@ -36,6 +35,11 @@ public class S3ApiCall extends BaseApiCall {
                                                              .httpClient(UrlConnectionHttpClient.builder().build())
                                                              .credentialsProvider(CREDENTIALS_PROVIDER_CHAIN).build();
 
+    private S3AsyncClient s3ClientWithNettyClient = S3AsyncClient.builder()
+                                                                 .region(Region.US_WEST_2)
+                                                                 .httpClient(NettyNioAsyncHttpClient.builder().build())
+                                                                 .credentialsProvider(CREDENTIALS_PROVIDER_CHAIN).build();
+
     public S3ApiCall() {
         super("s3");
     }
@@ -50,9 +54,8 @@ public Runnable urlHttpConnectionClientRunnable() {
         return () -> s3ClientWithHttpUrlConnection.listBuckets();
     }
 
-    //TODO: testing netty client once it's fixed
     @Override
     public Runnable nettyClientRunnable() {
-        return () -> logger.info("Skipping testing s3 client with netty client");
+        return () -> s3ClientWithNettyClient.listBuckets().join();
     }
 }